From bea721349ab0d7079a3f306b1b70459a3435531e Mon Sep 17 00:00:00 2001 From: Florent gravin Date: Fri, 3 Oct 2014 09:00:43 +0200 Subject: [PATCH] Rename gml format files to match convention also changes some comments and syntax (feedback from PR comments --- src/ol/format/gml/{v2.js => gml2.js} | 0 src/ol/format/gml/{v3.js => gml3.js} | 0 src/ol/format/gml/{base.js => gmlbase.js} | 8 +++++--- 3 files changed, 5 insertions(+), 3 deletions(-) rename src/ol/format/gml/{v2.js => gml2.js} (100%) rename src/ol/format/gml/{v3.js => gml3.js} (100%) rename src/ol/format/gml/{base.js => gmlbase.js} (98%) diff --git a/src/ol/format/gml/v2.js b/src/ol/format/gml/gml2.js similarity index 100% rename from src/ol/format/gml/v2.js rename to src/ol/format/gml/gml2.js diff --git a/src/ol/format/gml/v3.js b/src/ol/format/gml/gml3.js similarity index 100% rename from src/ol/format/gml/v3.js rename to src/ol/format/gml/gml3.js diff --git a/src/ol/format/gml/base.js b/src/ol/format/gml/gmlbase.js similarity index 98% rename from src/ol/format/gml/base.js rename to src/ol/format/gml/gmlbase.js index 13f80f8818..4f11887060 100644 --- a/src/ol/format/gml/base.js +++ b/src/ol/format/gml/gmlbase.js @@ -27,8 +27,10 @@ goog.require('ol.xml'); /** * @classdesc - * Feature format for reading and writing data in the GML format. - * Currently only supports GML 3.1.1 Simple Features profile. + * Feature base format for reading and writing data in the GML format. + * This class cannot be instantiate, it contains only base content that + * is shared with versioned format classes ol.format.GML2 and + * ol.format.GML3. * * @constructor * @param {olx.format.GMLOptions=} opt_options @@ -515,7 +517,7 @@ ol.format.GMLBase.prototype.readGeometryFromNode = function(node, opt_options) { var geometry = this.readGeometryElement(node, [this.getReadOptions(node, goog.isDef(opt_options) ? opt_options : {})]); - return (goog.isDef(geometry) ? geometry : null); + return goog.isDef(geometry) ? geometry : null; };