ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Only update the rbush item if the extent has changed

Browse Source
This commit is contained in:
Frederic Junod
2015-01-14 10:40:56 +01:00
parent 017ff47bf8
commit baf424f99c
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/ol/structs/rbush.js
View File

@@ -4,6 +4,7 @@ goog.require('goog.array');
goog.require('goog.asserts');
goog.require('goog.object');
goog.require('ol.ext.rbush');
goog.require('ol.extent');
@@ -123,8 +124,17 @@ ol.structs.RBush.prototype.remove = function(value) {
* @param {T} value Value.
*/
ol.structs.RBush.prototype.update = function(extent, value) {
this.remove(value);
this.insert(extent, value);
var uid = goog.getUid(value);
goog.asserts.assert(goog.object.containsKey(this.items_, uid));
var item = this.items_[uid];
if (!ol.extent.equals(item.slice(0, 4), extent)) {
if (goog.DEBUG && this.readers_) {
throw new Error('Can not update extent while reading');
}
this.remove(value);
this.insert(extent, value);
}
};

8
test/spec/ol/structs/rbush.test.js
View File

@@ -44,6 +44,14 @@ describe('ol.structs.RBush', function() {
expect(rBush.getInExtent([2, 2, 3, 3])).to.eql([obj]);
});
it('don\'t throws an exception if the extent is not modified', function() {
expect(function() {
rBush.forEach(function(value) {
rBush.update([0, 0, 1, 1], obj);
});
}).not.to.throwException();
});
});
describe('with a few objects', function() {