ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-11-05 21:23:55 +00:00
parent 0d2760831d
commit b916be5489
3 changed files with 51 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/Handler/Feature.html
View File

@@ -291,6 +291,32 @@
// 3 tests total
}
function test_destroyed_feature(t) {
t.plan(2);
var map = new OpenLayers.Map('map');
var control = new OpenLayers.Control();
map.addControl(control);
var layer = new OpenLayers.Layer();
layer.removeFeatures = function() {};
var feature = new OpenLayers.Feature.Vector(new OpenLayers.Geometry.Point(0,0));
feature.layer = layer;
layer.getFeatureFromEvent = function(evt) {return feature};
map.addLayer(layer);
var handler = new OpenLayers.Handler.Feature(control, layer);
handler.activate();
var count = 0;
handler.callback = function(type, featurelist) {
++count;
t.eq(featurelist[0].id, feature.id, type + ": correct feature sent to callback");
}
handler.handle({type: "click"});
// now destroy the feature and confirm that the callback is not called again
feature.destroy();
handler.handle({type: "click"});
t.eq(count, 1, "callback not called after destroy");
}
</script>
</head>
<body>