From b8addb4c24c9581ca5d0386fa174d97d398a1e26 Mon Sep 17 00:00:00 2001 From: William Wall Date: Wed, 3 Oct 2018 16:08:26 -0600 Subject: [PATCH] Fix missing method declaration ol/renderer/vector was using the abstract ReplayGroup type while referencing replayGroup.addDeclutter(), which was only defined on the canvas and webgl implementations and was also defined differently. --- src/ol/render/ReplayGroup.js | 7 +++++++ src/ol/render/canvas/ReplayGroup.js | 3 +-- src/ol/render/webgl/ReplayGroup.js | 7 ++++--- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/ol/render/ReplayGroup.js b/src/ol/render/ReplayGroup.js index 0775234e17..e6f85cf0c4 100644 --- a/src/ol/render/ReplayGroup.js +++ b/src/ol/render/ReplayGroup.js @@ -18,6 +18,13 @@ class ReplayGroup { * @return {boolean} Is empty. */ isEmpty() {} + + /** + * @abstract + * @param {boolean} group Group with previous replay + * @return {Array<*>} The resulting instruction group + */ + addDeclutter(group) {} } export default ReplayGroup; diff --git a/src/ol/render/canvas/ReplayGroup.js b/src/ol/render/canvas/ReplayGroup.js index fcaf49cce3..ed1dda0060 100644 --- a/src/ol/render/canvas/ReplayGroup.js +++ b/src/ol/render/canvas/ReplayGroup.js @@ -120,8 +120,7 @@ class CanvasReplayGroup extends ReplayGroup { } /** - * @param {boolean} group Group with previous replay. - * @return {import("../canvas.js").DeclutterGroup} Declutter instruction group. + * @inheritDoc */ addDeclutter(group) { let declutter = null; diff --git a/src/ol/render/webgl/ReplayGroup.js b/src/ol/render/webgl/ReplayGroup.js index 6e3959dd89..07528d59f9 100644 --- a/src/ol/render/webgl/ReplayGroup.js +++ b/src/ol/render/webgl/ReplayGroup.js @@ -67,10 +67,11 @@ class WebGLReplayGroup extends ReplayGroup { } /** - * @param {import("../../style/Style.js").default} style Style. - * @param {boolean} group Group with previous replay. + * @inheritDoc */ - addDeclutter(style, group) {} + addDeclutter(group) { + return []; + } /** * @param {import("../../webgl/Context.js").default} context WebGL context.