ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't dispatch select event if a selected feature is selected again

Browse Source
This commit is contained in:
Frederic Junod
2016-06-02 17:38:47 +02:00
parent e7c2d9ab32
commit b562f4d68a
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ol/interaction/selectinteraction.js
+2 -2
View File
@@ -281,9 +281,9 @@ ol.interaction.Select.handleEvent = function(mapBrowserEvent) {
return !this.multi_; return !this.multi_;
} }
}, this, this.layerFilter_); }, this, this.layerFilter_);
if (selected.length > 0 && features.getLength() == 1 && if (selected.length > 0 && features.getLength() == 1 && features.item(0) == selected[0]) {
features.item(0) == selected[0]) {
// No change; an already selected feature is selected again // No change; an already selected feature is selected again
selected.length = 0;
} else { } else {
if (features.getLength() !== 0) { if (features.getLength() !== 0) {
deselected = Array.prototype.concat(features.getArray()); deselected = Array.prototype.concat(features.getArray());
test/spec/ol/interaction/selectinteraction.test.js
+14
View File
@@ -144,6 +144,20 @@ describe('ol.interaction.Select', function() {
expect(features.getLength()).to.equal(0); expect(features.getLength()).to.equal(0);
}); });
it('select twice with single-click', function() {
var listenerSpy = sinon.spy(function(e) {
expect(e.selected).to.have.length(1);
});
select.on('select', listenerSpy);
simulateEvent(ol.MapBrowserEvent.EventType.SINGLECLICK, 10, -20);
simulateEvent(ol.MapBrowserEvent.EventType.SINGLECLICK, 9, -21);
expect(listenerSpy.callCount).to.be(1);
var features = select.getFeatures();
expect(features.getLength()).to.equal(1);
});
it('select with shift single-click', function() { it('select with shift single-click', function() {
var listenerSpy = sinon.spy(function(e) { var listenerSpy = sinon.spy(function(e) {