diff --git a/examples/custom-controls.js b/examples/custom-controls.js index 3dec81a30b..c32fad8698 100644 --- a/examples/custom-controls.js +++ b/examples/custom-controls.js @@ -50,7 +50,6 @@ app.RotateNorthControl = function(opt_options) { ol.control.Control.call(this, { element: element, - map: options.map, target: options.target }); diff --git a/src/objectliterals.jsdoc b/src/objectliterals.jsdoc index 8b94acbd1f..b85574c7dd 100644 --- a/src/objectliterals.jsdoc +++ b/src/objectliterals.jsdoc @@ -152,14 +152,12 @@ /** * @typedef {Object} ol.control.AttributionOptions * @property {string|undefined} className CSS class name. Default is 'ol-attribution'. - * @property {ol.Map|undefined} map Map. * @property {Element|undefined} target Target. */ /** * @typedef {Object} ol.control.ControlOptions * @property {Element|undefined} element Element. - * @property {ol.Map|undefined} map Map. * @property {Element|undefined} target Target. */ @@ -178,14 +176,12 @@ * @typedef {Object} ol.control.FullScreenOptions * @property {string|undefined} className CSS class name. Default is 'ol-full-screen'. * @property {boolean|undefined} keys Full keyboard access. - * @property {ol.Map|undefined} map Map. * @property {Element|undefined} target Target. */ /** * @typedef {Object} ol.control.LogoOptions * @property {string|undefined} className CSS class name. Default is 'ol-logo'. - * @property {ol.Map|undefined} map Map. * @property {Element|undefined} target Target. */ @@ -194,7 +190,6 @@ * @property {string|undefined} className CSS class name. Default is 'ol-mouse-position'. * @property {ol.CoordinateFormatType|undefined} coordinateFormat Coordinate * format. - * @property {ol.Map|undefined} map Map. * @property {ol.ProjectionLike} projection Projection. * @property {Element|undefined} target Target. * @property {string|undefined} undefinedHTML Markup for undefined coordinates. @@ -204,7 +199,6 @@ /** * @typedef {Object} ol.control.ScaleLineOptions * @property {string|undefined} className CSS Class name. Default is 'ol-scale-line'. - * @property {ol.Map|undefined} map Map. * @property {number|undefined} minWidth Minimum width in pixels. * @property {Element|undefined} target Target. * @property {ol.control.ScaleLineUnits|undefined} units Units. @@ -214,14 +208,12 @@ * @typedef {Object} ol.control.ZoomOptions * @property {string|undefined} className CSS class name. Default is 'ol-zoom'. * @property {number|undefined} delta The zoom delta applied on each click. - * @property {ol.Map|undefined} map Map. * @property {Element|undefined} target Target. */ /** * @typedef {Object} ol.control.ZoomSliderOptions * @property {string|undefined} className CSS class name. - * @property {ol.Map|undefined} map Map. * @property {number|undefined} maxResolution Maximum resolution. * @property {number|undefined} minResolution Minimum resolution. */ @@ -229,7 +221,6 @@ /** * @typedef {Object} ol.control.ZoomToExtentOptions * @property {string|undefined} className Class name. - * @property {ol.Map|undefined} map Map. * @property {Element|undefined} target Target. * @property {ol.Extent|undefined} extent The extent to zoom to. If * undefined the validity extent of the view projection is used. diff --git a/src/ol/control/attributioncontrol.js b/src/ol/control/attributioncontrol.js index e3bd74f6d7..650b5ee180 100644 --- a/src/ol/control/attributioncontrol.js +++ b/src/ol/control/attributioncontrol.js @@ -41,7 +41,6 @@ ol.control.Attribution = function(opt_options) { goog.base(this, { element: element, - map: options.map, target: options.target }); diff --git a/src/ol/control/control.js b/src/ol/control/control.js index ce88bc89d9..5e3832ba05 100644 --- a/src/ol/control/control.js +++ b/src/ol/control/control.js @@ -45,10 +45,6 @@ ol.control.Control = function(options) { */ this.listenerKeys = []; - if (goog.isDef(options.map)) { - this.setMap(options.map); - } - }; goog.inherits(ol.control.Control, ol.Object); diff --git a/src/ol/control/dragboxcontrol.js b/src/ol/control/dragboxcontrol.js index 45b41f4403..a6a405b5a1 100644 --- a/src/ol/control/dragboxcontrol.js +++ b/src/ol/control/dragboxcontrol.js @@ -14,8 +14,7 @@ goog.require('ol.control.Control'); /** - * @typedef {{map: (ol.Map|undefined), - * startCoordinate: ol.Coordinate}} + * @typedef {{startCoordinate: ol.Coordinate}} */ ol.control.DragBoxOptions; @@ -43,8 +42,7 @@ ol.control.DragBox = function(options) { this.startCoordinate_ = options.startCoordinate; goog.base(this, { - element: element, - map: options.map + element: element }); }; diff --git a/src/ol/control/fullscreencontrol.js b/src/ol/control/fullscreencontrol.js index 66cf684227..2b455d2855 100644 --- a/src/ol/control/fullscreencontrol.js +++ b/src/ol/control/fullscreencontrol.js @@ -59,7 +59,6 @@ ol.control.FullScreen = function(opt_options) { goog.base(this, { element: element, - map: options.map, target: options.target }); diff --git a/src/ol/control/logocontrol.js b/src/ol/control/logocontrol.js index b3ce8f0de1..c7820f93bf 100644 --- a/src/ol/control/logocontrol.js +++ b/src/ol/control/logocontrol.js @@ -37,7 +37,6 @@ ol.control.Logo = function(opt_options) { goog.base(this, { element: element, - map: options.map, target: options.target }); diff --git a/src/ol/control/mousepositioncontrol.js b/src/ol/control/mousepositioncontrol.js index 03373d53fd..8a59f5a6c2 100644 --- a/src/ol/control/mousepositioncontrol.js +++ b/src/ol/control/mousepositioncontrol.js @@ -59,7 +59,6 @@ ol.control.MousePosition = function(opt_options) { goog.base(this, { element: element, - map: options.map, target: options.target }); diff --git a/src/ol/control/scalelinecontrol.js b/src/ol/control/scalelinecontrol.js index 0209806472..22aa2ed3b9 100644 --- a/src/ol/control/scalelinecontrol.js +++ b/src/ol/control/scalelinecontrol.js @@ -118,7 +118,6 @@ ol.control.ScaleLine = function(opt_options) { goog.base(this, { element: this.element_, - map: options.map, target: options.target }); diff --git a/src/ol/control/zoomcontrol.js b/src/ol/control/zoomcontrol.js index 33604f2474..986a2a8754 100644 --- a/src/ol/control/zoomcontrol.js +++ b/src/ol/control/zoomcontrol.js @@ -59,7 +59,6 @@ ol.control.Zoom = function(opt_options) { goog.base(this, { element: element, - map: options.map, target: options.target }); diff --git a/src/ol/control/zoomslidercontrol.js b/src/ol/control/zoomslidercontrol.js index d392d8286b..99936d3d85 100644 --- a/src/ol/control/zoomslidercontrol.js +++ b/src/ol/control/zoomslidercontrol.js @@ -91,8 +91,7 @@ ol.control.ZoomSlider = function(opt_options) { ], this.handleContainerClick_, false, this); goog.base(this, { - element: element, - map: options.map + element: element }); }; goog.inherits(ol.control.ZoomSlider, ol.control.Control); diff --git a/src/ol/control/zoomtoextentcontrol.js b/src/ol/control/zoomtoextentcontrol.js index a6ea3647d8..5da182165c 100644 --- a/src/ol/control/zoomtoextentcontrol.js +++ b/src/ol/control/zoomtoextentcontrol.js @@ -46,7 +46,6 @@ ol.control.ZoomToExtent = function(opt_options) { goog.base(this, { element: element, - map: options.map, target: options.target }); }; diff --git a/test/spec/ol/control/zoomslidercontrol.test.js b/test/spec/ol/control/zoomslidercontrol.test.js index a7265d1759..02dcb94896 100644 --- a/test/spec/ol/control/zoomslidercontrol.test.js +++ b/test/spec/ol/control/zoomslidercontrol.test.js @@ -6,11 +6,10 @@ describe('ol.control.ZoomSlider', function() { beforeEach(function() { target = document.createElement('div'); document.body.appendChild(target); + zoomslider = new ol.control.ZoomSlider(); map = new ol.Map({ - target: target - }); - zoomslider = new ol.control.ZoomSlider({ - map: map + target: target, + controls: [zoomslider] }); });