From 3557247b2751c87e37218c1c7a1da95a08963be9 Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Mon, 18 Feb 2019 17:31:36 +0100 Subject: [PATCH 1/2] Fix comments indentation --- src/ol/render/Feature.js | 138 +++++++++++++++++++-------------------- 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/src/ol/render/Feature.js b/src/ol/render/Feature.js index fa539e03a7..c26525bce4 100644 --- a/src/ol/render/Feature.js +++ b/src/ol/render/Feature.js @@ -33,70 +33,70 @@ const tmpTransform = createTransform(); class RenderFeature { constructor(type, flatCoordinates, ends, properties, id) { /** - * @private - * @type {import("../extent.js").Extent|undefined} - */ + * @private + * @type {import("../extent.js").Extent|undefined} + */ this.extent_; /** - * @private - * @type {number|string|undefined} - */ + * @private + * @type {number|string|undefined} + */ this.id_ = id; /** - * @private - * @type {GeometryType} - */ + * @private + * @type {GeometryType} + */ this.type_ = type; /** - * @private - * @type {Array} - */ + * @private + * @type {Array} + */ this.flatCoordinates_ = flatCoordinates; /** - * @private - * @type {Array} - */ + * @private + * @type {Array} + */ this.flatInteriorPoints_ = null; /** - * @private - * @type {Array} - */ + * @private + * @type {Array} + */ this.flatMidpoints_ = null; /** - * @private - * @type {Array|Array>} - */ + * @private + * @type {Array|Array>} + */ this.ends_ = ends; /** - * @private - * @type {Object} - */ + * @private + * @type {Object} + */ this.properties_ = properties; } /** - * Get a feature property by its key. - * @param {string} key Key - * @return {*} Value for the requested key. - * @api - */ + * Get a feature property by its key. + * @param {string} key Key + * @return {*} Value for the requested key. + * @api + */ get(key) { return this.properties_[key]; } /** - * Get the extent of this feature's geometry. - * @return {import("../extent.js").Extent} Extent. - * @api - */ + * Get the extent of this feature's geometry. + * @return {import("../extent.js").Extent} Extent. + * @api + */ getExtent() { if (!this.extent_) { this.extent_ = this.type_ === GeometryType.POINT ? @@ -109,8 +109,8 @@ class RenderFeature { } /** - * @return {Array} Flat interior points. - */ + * @return {Array} Flat interior points. + */ getFlatInteriorPoint() { if (!this.flatInteriorPoints_) { const flatCenter = getCenter(this.getExtent()); @@ -121,8 +121,8 @@ class RenderFeature { } /** - * @return {Array} Flat interior points. - */ + * @return {Array} Flat interior points. + */ getFlatInteriorPoints() { if (!this.flatInteriorPoints_) { const flatCenters = linearRingssCenter( @@ -134,8 +134,8 @@ class RenderFeature { } /** - * @return {Array} Flat midpoint. - */ + * @return {Array} Flat midpoint. + */ getFlatMidpoint() { if (!this.flatMidpoints_) { this.flatMidpoints_ = interpolatePoint( @@ -145,8 +145,8 @@ class RenderFeature { } /** - * @return {Array} Flat midpoints. - */ + * @return {Array} Flat midpoints. + */ getFlatMidpoints() { if (!this.flatMidpoints_) { this.flatMidpoints_ = []; @@ -165,28 +165,28 @@ class RenderFeature { } /** - * Get the feature identifier. This is a stable identifier for the feature and - * is set when reading data from a remote source. - * @return {number|string|undefined} Id. - * @api - */ + * Get the feature identifier. This is a stable identifier for the feature and + * is set when reading data from a remote source. + * @return {number|string|undefined} Id. + * @api + */ getId() { return this.id_; } /** - * @return {Array} Flat coordinates. - */ + * @return {Array} Flat coordinates. + */ getOrientedFlatCoordinates() { return this.flatCoordinates_; } /** - * For API compatibility with {@link module:ol/Feature~Feature}, this method is useful when - * determining the geometry type in style function (see {@link #getType}). - * @return {RenderFeature} Feature. - * @api - */ + * For API compatibility with {@link module:ol/Feature~Feature}, this method is useful when + * determining the geometry type in style function (see {@link #getType}). + * @return {RenderFeature} Feature. + * @api + */ getGeometry() { return this; } @@ -200,17 +200,17 @@ class RenderFeature { } /** - * Get the feature properties. - * @return {Object} Feature properties. - * @api - */ + * Get the feature properties. + * @return {Object} Feature properties. + * @api + */ getProperties() { return this.properties_; } /** - * @return {number} Stride. - */ + * @return {number} Stride. + */ getStride() { return 2; } @@ -223,21 +223,21 @@ class RenderFeature { } /** - * Get the type of this feature's geometry. - * @return {GeometryType} Geometry type. - * @api - */ + * Get the type of this feature's geometry. + * @return {GeometryType} Geometry type. + * @api + */ getType() { return this.type_; } /** - * Transform geometry coordinates from tile pixel space to projected. - * The SRS of the source and destination are expected to be the same. - * - * @param {import("../proj.js").ProjectionLike} source The current projection - * @param {import("../proj.js").ProjectionLike} destination The desired projection. - */ + * Transform geometry coordinates from tile pixel space to projected. + * The SRS of the source and destination are expected to be the same. + * + * @param {import("../proj.js").ProjectionLike} source The current projection + * @param {import("../proj.js").ProjectionLike} destination The desired projection. + */ transform(source, destination) { source = getProjection(source); const pixelExtent = source.getExtent(); From 746455a9b99397774dae206410dc0d5c0168a891 Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Mon, 18 Feb 2019 17:33:05 +0100 Subject: [PATCH 2/2] Move params list to the constructor function --- src/ol/render/Feature.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/ol/render/Feature.js b/src/ol/render/Feature.js index c26525bce4..4bbc9b7d52 100644 --- a/src/ol/render/Feature.js +++ b/src/ol/render/Feature.js @@ -22,15 +22,16 @@ const tmpTransform = createTransform(); * Lightweight, read-only, {@link module:ol/Feature~Feature} and {@link module:ol/geom/Geometry~Geometry} like * structure, optimized for vector tile rendering and styling. Geometry access * through the API is limited to getting the type and extent of the geometry. - * - * @param {GeometryType} type Geometry type. - * @param {Array} flatCoordinates Flat coordinates. These always need - * to be right-handed for polygons. - * @param {Array|Array>} ends Ends or Endss. - * @param {Object} properties Properties. - * @param {number|string|undefined} id Feature id. */ class RenderFeature { + /** + * @param {GeometryType} type Geometry type. + * @param {Array} flatCoordinates Flat coordinates. These always need + * to be right-handed for polygons. + * @param {Array|Array>} ends Ends or Endss. + * @param {Object} properties Properties. + * @param {number|string|undefined} id Feature id. + */ constructor(type, flatCoordinates, ends, properties, id) { /** * @private