From afa416fd2dbebc1d147b05e9a674f48e22d072de Mon Sep 17 00:00:00 2001 From: crschmidt Date: Wed, 28 Mar 2007 21:08:27 +0000 Subject: [PATCH] Set the ID of the image before registering events on it. The Event.observe call uses the element ID to cache the listeners for later deletion, so this closes a leak. git-svn-id: http://svn.openlayers.org/trunk/openlayers@2911 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf --- lib/OpenLayers/Util.js | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/OpenLayers/Util.js b/lib/OpenLayers/Util.js index f250977828..1ca26c0fab 100644 --- a/lib/OpenLayers/Util.js +++ b/lib/OpenLayers/Util.js @@ -175,6 +175,16 @@ OpenLayers.Util.createImage = function(id, px, sz, imgURL, position, border, image = document.createElement("img"); + //set generic properties + if (!id) { + id = OpenLayers.Util.createUniqueID("OpenLayersDiv"); + } + if (!position) { + position = "relative"; + } + OpenLayers.Util.modifyDOMElement(image, id, px, sz, position, + border, null, opacity); + if(delayDisplay) { image.style.display = "none"; OpenLayers.Event.observe(image, "load", @@ -191,15 +201,6 @@ OpenLayers.Util.createImage = function(id, px, sz, imgURL, position, border, image.src = imgURL; } - //set generic properties - if (!id) { - id = OpenLayers.Util.createUniqueID("OpenLayersDiv"); - } - if (!position) { - position = "relative"; - } - OpenLayers.Util.modifyDOMElement(image, id, px, sz, position, - border, null, opacity); return image;