From 09370952fdf5df3d70485e7cde21accbc937d22e Mon Sep 17 00:00:00 2001 From: Marc Jansen Date: Thu, 24 Mar 2016 14:42:52 +0100 Subject: [PATCH] Clarify that `lineDash` has no effect in IE < 10 --- externs/olx.js | 8 +++++++- src/ol/style/strokestyle.js | 6 ++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/externs/olx.js b/externs/olx.js index fcd2734d71..3178bea698 100644 --- a/externs/olx.js +++ b/externs/olx.js @@ -6713,7 +6713,13 @@ olx.style.StrokeOptions.prototype.lineJoin; /** - * Line dash pattern. Default is `undefined` (no dash). + * Line dash pattern. Default is `undefined` (no dash). Please note that + * Internet Explorer 10 and lower [do not support][mdn] the `setLineDash` + * method on the `CanvasRenderingContext2D` and therefore this option will + * have no visual effect in these browsers. + * + * [mdn]: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/setLineDash#Browser_compatibility + * * @type {Array.|undefined} * @api */ diff --git a/src/ol/style/strokestyle.js b/src/ol/style/strokestyle.js index 0c75cb4f6e..f4dee3854d 100644 --- a/src/ol/style/strokestyle.js +++ b/src/ol/style/strokestyle.js @@ -151,6 +151,12 @@ ol.style.Stroke.prototype.setLineCap = function(lineCap) { /** * Set the line dash. * + * Please note that Internet Explorer 10 and lower [do not support][mdn] the + * `setLineDash` method on the `CanvasRenderingContext2D` and therefore this + * property will have no visual effect in these browsers. + * + * [mdn]: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/setLineDash#Browser_compatibility + * * @param {Array.} lineDash Line dash. * @api */