Use blocked scoped variables

In addition to using const and let, this also upgrades our linter config and removes lint (mostly whitespace).
This commit is contained in:
Tim Schaub
2018-01-11 23:32:36 -07:00
parent 0bf2b04dee
commit ad62739a6e
684 changed files with 18120 additions and 18184 deletions

View File

@@ -17,7 +17,7 @@ describe('ol.transform', function() {
describe('ol.transform.reset()', function() {
it('resets tansform to an identity transform', function() {
var transform = [1, 2, 3, 4, 5, 6];
const transform = [1, 2, 3, 4, 5, 6];
expect(_ol_transform_.reset(transform)).to.eql([1, 0, 0, 1, 0, 0]);
expect(transform).to.eql([1, 0, 0, 1, 0, 0]);
});
@@ -25,7 +25,7 @@ describe('ol.transform', function() {
describe('ol.transform.set()', function() {
it('sets the given values', function() {
var transform = _ol_transform_.create();
const transform = _ol_transform_.create();
expect(_ol_transform_.set(transform, 1, 2, 3, 4, 5, 6)).to.eql([1, 2, 3, 4, 5, 6]);
expect(transform).to.eql([1, 2, 3, 4, 5, 6]);
});
@@ -33,8 +33,8 @@ describe('ol.transform', function() {
describe('ol.transform.setFromArray()', function() {
it('sets values of 2nd transform on 1st transform', function() {
var transform1 = _ol_transform_.create();
var transform2 = [1, 2, 3, 4, 5, 6];
const transform1 = _ol_transform_.create();
const transform2 = [1, 2, 3, 4, 5, 6];
expect(_ol_transform_.setFromArray(transform1, transform2)).to.eql(transform2);
expect(transform1).to.eql(transform2);
});
@@ -42,7 +42,7 @@ describe('ol.transform', function() {
describe('ol.transform.translate()', function() {
it('applies translation to a transform', function() {
var transform = _ol_transform_.create();
const transform = _ol_transform_.create();
expect(_ol_transform_.translate(transform, 3, 4)).to.eql([1, 0, 0, 1, 3, 4]);
expect(transform).to.eql([1, 0, 0, 1, 3, 4]);
});
@@ -50,7 +50,7 @@ describe('ol.transform', function() {
describe('ol.transform.scale()', function() {
it('applies scaling to a transform', function() {
var transform = _ol_transform_.create();
const transform = _ol_transform_.create();
expect(_ol_transform_.scale(transform, 3, 4)).to.eql([3, 0, 0, 4, 0, 0]);
expect(transform).to.eql([3, 0, 0, 4, 0, 0]);
});
@@ -58,7 +58,7 @@ describe('ol.transform', function() {
describe('ol.transform.rotate()', function() {
it('applies rotation to a transform', function() {
var transform = _ol_transform_.create();
const transform = _ol_transform_.create();
assertRoughlyEqual(_ol_transform_.rotate(transform, Math.PI / 2), [0, 1, -1, 0, 0, 0]);
assertRoughlyEqual(transform, [0, 1, -1, 0, 0, 0]);
});
@@ -66,8 +66,8 @@ describe('ol.transform', function() {
describe('ol.transform.multiply()', function() {
it('multiplies two transforms', function() {
var transform1 = [1, 2, 1, 2, 1, 2];
var transform2 = [1, 2, 1, 2, 1, 2];
const transform1 = [1, 2, 1, 2, 1, 2];
const transform2 = [1, 2, 1, 2, 1, 2];
expect(_ol_transform_.multiply(transform1, transform2)).to.eql([3, 6, 3, 6, 4, 8]);
expect(transform1).to.eql([3, 6, 3, 6, 4, 8]);
});
@@ -75,22 +75,22 @@ describe('ol.transform', function() {
describe('ol.transform.compose()', function() {
it('composes a translate, scale, rotate, translate transform', function() {
var dx1 = 3;
var dy1 = 4;
var sx = 1.5;
var sy = -1.5;
var angle = Math.PI / 3;
var dx2 = -dx1 / 2;
var dy2 = -dy1 / 2;
const dx1 = 3;
const dy1 = 4;
const sx = 1.5;
const sy = -1.5;
const angle = Math.PI / 3;
const dx2 = -dx1 / 2;
const dy2 = -dy1 / 2;
var expected = _ol_transform_.create();
const expected = _ol_transform_.create();
_ol_transform_.translate(expected, dx1, dy1);
_ol_transform_.scale(expected, sx, sy);
_ol_transform_.rotate(expected, angle);
_ol_transform_.translate(expected, dx2, dy2);
var composed = _ol_transform_.create();
var composedReturn = _ol_transform_.compose(composed, dx1, dy1, sx, sy, angle, dx2, dy2);
const composed = _ol_transform_.create();
const composedReturn = _ol_transform_.compose(composed, dx1, dy1, sx, sy, angle, dx2, dy2);
expect(composed).to.equal(composedReturn);
expect(composed).to.eql(expected);
});
@@ -98,7 +98,7 @@ describe('ol.transform', function() {
describe('ol.transform.invert()', function() {
it('inverts a transform', function() {
var transform = [1, 0, 1, 0, 1, 0];
let transform = [1, 0, 1, 0, 1, 0];
expect(function() {
_ol_transform_.invert(transform);
}).to.throwException();
@@ -110,8 +110,8 @@ describe('ol.transform', function() {
describe('ol.transform.apply()', function() {
it('applies a transform to a 2d vector', function() {
var transform = _ol_transform_.translate(_ol_transform_.create(), 2, 3);
var point = [1, 2];
const transform = _ol_transform_.translate(_ol_transform_.create(), 2, 3);
const point = [1, 2];
expect(_ol_transform_.apply(transform, point)).to.eql([3, 5]);
expect(point).to.eql([3, 5]);
});