From ab9fc9cc710dba16d628bb38e9f7f8890c927323 Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Tue, 7 May 2013 16:28:22 +0200 Subject: [PATCH] Inline simple function that is only called once --- src/ol/control/zoomslidercontrol.js | 35 +++++++++-------------------- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/src/ol/control/zoomslidercontrol.js b/src/ol/control/zoomslidercontrol.js index 5af6be81e6..a4281cfed1 100644 --- a/src/ol/control/zoomslidercontrol.js +++ b/src/ol/control/zoomslidercontrol.js @@ -58,17 +58,23 @@ ol.control.ZoomSlider = function(options) { */ this.draggerListenerKeys_ = null; - var elem = this.createDom_(); - this.dragger_ = this.createDraggable_(elem); + var sliderCssCls = ol.control.ZoomSlider.CSS_CLASS_CONTAINER + ' ' + + ol.css.CLASS_UNSELECTABLE; + var thumbCssCls = ol.control.ZoomSlider.CSS_CLASS_THUMB + ' ' + + ol.css.CLASS_UNSELECTABLE; + var element = goog.dom.createDom(goog.dom.TagName.DIV, sliderCssCls, + goog.dom.createDom(goog.dom.TagName.DIV, thumbCssCls)); + + this.dragger_ = this.createDraggable_(element); // FIXME currently only a do nothing function is bound. - goog.events.listen(elem, [ + goog.events.listen(element, [ goog.events.EventType.TOUCHEND, goog.events.EventType.CLICK ], this.handleContainerClick_, false, this); goog.base(this, { - element: elem, + element: element, map: options.map }); }; @@ -299,24 +305,3 @@ ol.control.ZoomSlider.prototype.createDraggable_ = function(elem) { ]; return dragger; }; - - -/** - * Setup the DOM-structure we need for the zoomslider. - * - * @param {Element=} opt_elem The element for the slider. - * @return {Element} The correctly set up DOMElement. - * @private - */ -ol.control.ZoomSlider.prototype.createDom_ = function(opt_elem) { - var elem, - sliderCssCls = ol.control.ZoomSlider.CSS_CLASS_CONTAINER + ' ' + - ol.css.CLASS_UNSELECTABLE, - thumbCssCls = ol.control.ZoomSlider.CSS_CLASS_THUMB + ' ' + - ol.css.CLASS_UNSELECTABLE; - - elem = goog.dom.createDom(goog.dom.TagName.DIV, sliderCssCls, - goog.dom.createDom(goog.dom.TagName.DIV, thumbCssCls)); - - return elem; -};