From 35266c47a3fae1d54613f8d983dd779f3d681e7a Mon Sep 17 00:00:00 2001 From: mike-000 <49240900+mike-000@users.noreply.github.com> Date: Mon, 23 Nov 2020 14:35:40 +0000 Subject: [PATCH 1/3] document fromCircle angle direction and 0 --- src/ol/geom/Polygon.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ol/geom/Polygon.js b/src/ol/geom/Polygon.js index e0c169025b..3b4aa7e94a 100644 --- a/src/ol/geom/Polygon.js +++ b/src/ol/geom/Polygon.js @@ -470,7 +470,7 @@ export function fromExtent(extent) { * @param {import("./Circle.js").default} circle Circle geometry. * @param {number=} opt_sides Number of sides of the polygon. Default is 32. * @param {number=} opt_angle Start angle for the first vertex of the polygon in - * radians. Default is 0. + * counter-clockwise radians. 0 means East. Default is 0. * @return {Polygon} Polygon geometry. * @api */ @@ -500,7 +500,7 @@ export function fromCircle(circle, opt_sides, opt_angle) { * @param {import("../coordinate.js").Coordinate} center Center of the regular polygon. * @param {number} radius Radius of the regular polygon. * @param {number=} opt_angle Start angle for the first vertex of the polygon in - * radians. Default is 0. + * counter-clockwise radians. 0 means East. Default is 0. */ export function makeRegular(polygon, center, radius, opt_angle) { const flatCoordinates = polygon.getFlatCoordinates(); From 540e5faa7405dddc31b4a134de9d8730755551e8 Mon Sep 17 00:00:00 2001 From: mike-000 <49240900+mike-000@users.noreply.github.com> Date: Mon, 23 Nov 2020 14:41:19 +0000 Subject: [PATCH 2/3] document rotation direction --- src/ol/geom/SimpleGeometry.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ol/geom/SimpleGeometry.js b/src/ol/geom/SimpleGeometry.js index 1f8b244694..7119ebd5d9 100644 --- a/src/ol/geom/SimpleGeometry.js +++ b/src/ol/geom/SimpleGeometry.js @@ -217,7 +217,7 @@ class SimpleGeometry extends Geometry { /** * Rotate the geometry around a given coordinate. This modifies the geometry * coordinates in place. - * @param {number} angle Rotation angle in radians. + * @param {number} angle Rotation angle in counter-clockwise radians. * @param {import("../coordinate.js").Coordinate} anchor The rotation center. * @api */ From 1c529a9e2f3f3e9b7a82629658fb398135bf5678 Mon Sep 17 00:00:00 2001 From: mike-000 <49240900+mike-000@users.noreply.github.com> Date: Mon, 23 Nov 2020 14:41:30 +0000 Subject: [PATCH 3/3] document rotation direction --- src/ol/geom/Circle.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ol/geom/Circle.js b/src/ol/geom/Circle.js index ddd87ca1cb..b120e0873d 100644 --- a/src/ol/geom/Circle.js +++ b/src/ol/geom/Circle.js @@ -227,7 +227,7 @@ class Circle extends SimpleGeometry { /** * Rotate the geometry around a given coordinate. This modifies the geometry * coordinates in place. - * @param {number} angle Rotation angle in radians. + * @param {number} angle Rotation angle in counter-clockwise radians. * @param {import("../coordinate.js").Coordinate} anchor The rotation center. * @api */