Rename ol.Map#requestRenderFrame to ol.Map#render

This commit is contained in:
Tom Payne
2014-02-20 16:31:43 +01:00
parent ebdb5dce22
commit a8f932fa07
18 changed files with 45 additions and 45 deletions

View File

@@ -48,6 +48,6 @@ map.on('postcompose', function(event) {
vectorContext.setImageStyle(imageStyle); vectorContext.setImageStyle(imageStyle);
vectorContext.drawMultiPointGeometry( vectorContext.drawMultiPointGeometry(
new ol.geom.MultiPoint(coordinates), null); new ol.geom.MultiPoint(coordinates), null);
map.requestRenderFrame(); map.render();
}); });
map.requestRenderFrame(); map.render();

View File

@@ -102,7 +102,7 @@ var displaySnap = function(coordinate) {
line.setCoordinates(coordinates); line.setCoordinates(coordinates);
} }
} }
map.requestRenderFrame(); map.render();
}; };
$(map.getViewport()).on('mousemove', function(evt) { $(map.getViewport()).on('mousemove', function(evt) {

View File

@@ -28,10 +28,10 @@ var radius = 75;
$(document).keydown(function(evt) { $(document).keydown(function(evt) {
if (evt.which === 38) { if (evt.which === 38) {
radius = Math.min(radius + 5, 150); radius = Math.min(radius + 5, 150);
map.requestRenderFrame(); map.render();
} else if (evt.which === 40) { } else if (evt.which === 40) {
radius = Math.max(radius - 5, 25); radius = Math.max(radius - 5, 25);
map.requestRenderFrame(); map.render();
} }
}); });
@@ -39,10 +39,10 @@ $(document).keydown(function(evt) {
var mousePosition = null; var mousePosition = null;
$(map.getViewport()).on('mousemove', function(evt) { $(map.getViewport()).on('mousemove', function(evt) {
mousePosition = map.getEventPixel(evt.originalEvent); mousePosition = map.getEventPixel(evt.originalEvent);
map.requestRenderFrame(); map.render();
}).on('mouseout', function() { }).on('mouseout', function() {
mousePosition = null; mousePosition = null;
map.requestRenderFrame(); map.render();
}); });
// before rendering the layer, do some clipping // before rendering the layer, do some clipping

View File

@@ -42,5 +42,5 @@ bing.on('postcompose', function(event) {
}); });
swipe.addEventListener('input', function() { swipe.addEventListener('input', function() {
map.requestRenderFrame(); map.render();
}, false); }, false);

View File

@@ -87,7 +87,7 @@ var displaySnap = function(coordinate) {
line.setCoordinates([coordinate, closestPoint]); line.setCoordinates([coordinate, closestPoint]);
} }
} }
map.requestRenderFrame(); map.render();
}; };
$(map.getViewport()).on('mousemove', function(evt) { $(map.getViewport()).on('mousemove', function(evt) {

View File

@@ -105,7 +105,7 @@ ol.FeatureOverlay.prototype.getFeatures = function() {
* @private * @private
*/ */
ol.FeatureOverlay.prototype.handleFeatureChange_ = function() { ol.FeatureOverlay.prototype.handleFeatureChange_ = function() {
this.requestRenderFrame_(); this.render_();
}; };
@@ -120,7 +120,7 @@ ol.FeatureOverlay.prototype.handleFeaturesAdd_ =
this.featureChangeListenerKeys_[goog.getUid(feature).toString()] = this.featureChangeListenerKeys_[goog.getUid(feature).toString()] =
goog.events.listen(feature, goog.events.EventType.CHANGE, goog.events.listen(feature, goog.events.EventType.CHANGE,
this.handleFeatureChange_, false, this); this.handleFeatureChange_, false, this);
this.requestRenderFrame_(); this.render_();
}; };
@@ -135,7 +135,7 @@ ol.FeatureOverlay.prototype.handleFeaturesRemove_ =
var key = goog.getUid(feature).toString(); var key = goog.getUid(feature).toString();
goog.events.unlistenByKey(this.featureChangeListenerKeys_[key]); goog.events.unlistenByKey(this.featureChangeListenerKeys_[key]);
delete this.featureChangeListenerKeys_[key]; delete this.featureChangeListenerKeys_[key];
this.requestRenderFrame_(); this.render_();
}; };
@@ -175,9 +175,9 @@ ol.FeatureOverlay.prototype.removeFeature = function(feature) {
/** /**
* @private * @private
*/ */
ol.FeatureOverlay.prototype.requestRenderFrame_ = function() { ol.FeatureOverlay.prototype.render_ = function() {
if (!goog.isNull(this.map_)) { if (!goog.isNull(this.map_)) {
this.map_.requestRenderFrame(); this.map_.render();
} }
}; };
@@ -216,7 +216,7 @@ ol.FeatureOverlay.prototype.setFeatures = function(features) {
this.handleFeatureChange_, false, this); this.handleFeatureChange_, false, this);
} }
} }
this.requestRenderFrame_(); this.render_();
}; };
@@ -229,13 +229,13 @@ ol.FeatureOverlay.prototype.setMap = function(map) {
goog.events.unlistenByKey(this.postComposeListenerKey_); goog.events.unlistenByKey(this.postComposeListenerKey_);
this.postComposeListenerKey_ = null; this.postComposeListenerKey_ = null;
} }
this.requestRenderFrame_(); this.render_();
this.map_ = map; this.map_ = map;
if (!goog.isNull(map)) { if (!goog.isNull(map)) {
this.postComposeListenerKey_ = goog.events.listen( this.postComposeListenerKey_ = goog.events.listen(
map, ol.render.EventType.POSTCOMPOSE, this.handleMapPostCompose_, false, map, ol.render.EventType.POSTCOMPOSE, this.handleMapPostCompose_, false,
this); this);
map.requestRenderFrame(); map.render();
} }
}; };
@@ -251,7 +251,7 @@ ol.FeatureOverlay.prototype.setMap = function(map) {
ol.FeatureOverlay.prototype.setStyle = function(style) { ol.FeatureOverlay.prototype.setStyle = function(style) {
this.style_ = style; this.style_ = style;
this.styleFunction_ = ol.feature.createStyleFunction(style); this.styleFunction_ = ol.feature.createStyleFunction(style);
this.requestRenderFrame_(); this.render_();
}; };

View File

@@ -71,7 +71,7 @@ ol.interaction.DragPan.prototype.handleDrag = function(mapBrowserEvent) {
ol.coordinate.rotate(newCenter, view2DState.rotation); ol.coordinate.rotate(newCenter, view2DState.rotation);
ol.coordinate.add(newCenter, this.startCenter); ol.coordinate.add(newCenter, this.startCenter);
newCenter = view.constrainCenter(newCenter); newCenter = view.constrainCenter(newCenter);
map.requestRenderFrame(); map.render();
view.setCenter(newCenter); view.setCenter(newCenter);
}; };
@@ -104,7 +104,7 @@ ol.interaction.DragPan.prototype.handleDragEnd = function(mapBrowserEvent) {
dest = view2D.constrainCenter(dest); dest = view2D.constrainCenter(dest);
view2D.setCenter(dest); view2D.setCenter(dest);
} }
map.requestRenderFrame(); map.render();
}; };
@@ -120,7 +120,7 @@ ol.interaction.DragPan.prototype.handleDragStart = function(mapBrowserEvent) {
} }
var map = mapBrowserEvent.map; var map = mapBrowserEvent.map;
map.getView().setHint(ol.ViewHint.INTERACTING, 1); map.getView().setHint(ol.ViewHint.INTERACTING, 1);
map.requestRenderFrame(); map.render();
return true; return true;
} else { } else {
return false; return false;
@@ -139,7 +139,7 @@ ol.interaction.DragPan.prototype.handleDown = function(mapBrowserEvent) {
goog.asserts.assert(!goog.isNull(mapBrowserEvent.frameState)); goog.asserts.assert(!goog.isNull(mapBrowserEvent.frameState));
if (!goog.isNull(this.kineticPreRenderFn_) && if (!goog.isNull(this.kineticPreRenderFn_) &&
map.removePreRenderFunction(this.kineticPreRenderFn_)) { map.removePreRenderFunction(this.kineticPreRenderFn_)) {
map.requestRenderFrame(); map.render();
view.setCenter(mapBrowserEvent.frameState.view2DState.center); view.setCenter(mapBrowserEvent.frameState.view2DState.center);
this.kineticPreRenderFn_ = null; this.kineticPreRenderFn_ = null;
} }

View File

@@ -80,7 +80,7 @@ ol.interaction.DragRotateAndZoom.prototype.handleDrag =
// FIXME works for View2D only // FIXME works for View2D only
var view = map.getView().getView2D(); var view = map.getView().getView2D();
var view2DState = view.getView2DState(); var view2DState = view.getView2DState();
map.requestRenderFrame(); map.render();
if (goog.isDef(this.lastAngle_)) { if (goog.isDef(this.lastAngle_)) {
var angleDelta = theta - this.lastAngle_; var angleDelta = theta - this.lastAngle_;
ol.interaction.Interaction.rotateWithoutConstraints( ol.interaction.Interaction.rotateWithoutConstraints(

View File

@@ -60,7 +60,7 @@ ol.interaction.DragRotate.prototype.handleDrag = function(mapBrowserEvent) {
// FIXME works for View2D only // FIXME works for View2D only
var view = map.getView().getView2D(); var view = map.getView().getView2D();
var view2DState = view.getView2DState(); var view2DState = view.getView2DState();
map.requestRenderFrame(); map.render();
ol.interaction.Interaction.rotateWithoutConstraints( ol.interaction.Interaction.rotateWithoutConstraints(
map, view, view2DState.rotation - delta); map, view, view2DState.rotation - delta);
} }
@@ -92,7 +92,7 @@ ol.interaction.DragRotate.prototype.handleDragStart =
if (browserEvent.isMouseActionButton() && this.condition_(mapBrowserEvent)) { if (browserEvent.isMouseActionButton() && this.condition_(mapBrowserEvent)) {
var map = mapBrowserEvent.map; var map = mapBrowserEvent.map;
map.getView().setHint(ol.ViewHint.INTERACTING, 1); map.getView().setHint(ol.ViewHint.INTERACTING, 1);
map.requestRenderFrame(); map.render();
this.lastAngle_ = undefined; this.lastAngle_ = undefined;
return true; return true;
} else { } else {

View File

@@ -68,7 +68,7 @@ ol.interaction.KeyboardZoom.prototype.handleMapBrowserEvent =
(charCode == '+'.charCodeAt(0) || charCode == '-'.charCodeAt(0))) { (charCode == '+'.charCodeAt(0) || charCode == '-'.charCodeAt(0))) {
var map = mapBrowserEvent.map; var map = mapBrowserEvent.map;
var delta = (charCode == '+'.charCodeAt(0)) ? this.delta_ : -this.delta_; var delta = (charCode == '+'.charCodeAt(0)) ? this.delta_ : -this.delta_;
map.requestRenderFrame(); map.render();
// FIXME works for View2D only // FIXME works for View2D only
var view = map.getView().getView2D(); var view = map.getView().getView2D();
ol.interaction.Interaction.zoomByDelta( ol.interaction.Interaction.zoomByDelta(

View File

@@ -114,7 +114,7 @@ ol.interaction.MouseWheelZoom.prototype.doZoom_ = function(map) {
// FIXME works for View2D only // FIXME works for View2D only
var view = map.getView().getView2D(); var view = map.getView().getView2D();
map.requestRenderFrame(); map.render();
ol.interaction.Interaction.zoomByDelta(map, view, -delta, this.lastAnchor_, ol.interaction.Interaction.zoomByDelta(map, view, -delta, this.lastAnchor_,
this.duration_); this.duration_);

View File

@@ -73,7 +73,7 @@ ol.interaction.TouchPan.prototype.handleTouchMove = function(mapBrowserEvent) {
ol.coordinate.rotate(center, view2DState.rotation); ol.coordinate.rotate(center, view2DState.rotation);
ol.coordinate.add(center, view2DState.center); ol.coordinate.add(center, view2DState.center);
center = view2D.constrainCenter(center); center = view2D.constrainCenter(center);
map.requestRenderFrame(); map.render();
view2D.setCenter(center); view2D.setCenter(center);
} }
this.lastCentroid = centroid; this.lastCentroid = centroid;
@@ -104,7 +104,7 @@ ol.interaction.TouchPan.prototype.handleTouchEnd =
dest = view2D.constrainCenter(dest); dest = view2D.constrainCenter(dest);
view2D.setCenter(dest); view2D.setCenter(dest);
} }
map.requestRenderFrame(); map.render();
return false; return false;
} else { } else {
this.lastCentroid = null; this.lastCentroid = null;
@@ -123,7 +123,7 @@ ol.interaction.TouchPan.prototype.handleTouchStart =
var view2D = map.getView().getView2D(); var view2D = map.getView().getView2D();
goog.asserts.assertInstanceof(view2D, ol.View2D); goog.asserts.assertInstanceof(view2D, ol.View2D);
this.lastCentroid = null; this.lastCentroid = null;
map.requestRenderFrame(); map.render();
if (!goog.isNull(this.kineticPreRenderFn_) && if (!goog.isNull(this.kineticPreRenderFn_) &&
map.removePreRenderFunction(this.kineticPreRenderFn_)) { map.removePreRenderFunction(this.kineticPreRenderFn_)) {
view2D.setCenter(mapBrowserEvent.frameState.view2DState.center); view2D.setCenter(mapBrowserEvent.frameState.view2DState.center);

View File

@@ -107,7 +107,7 @@ ol.interaction.TouchRotate.prototype.handleTouchMove =
// FIXME works for View2D only // FIXME works for View2D only
var view = map.getView().getView2D(); var view = map.getView().getView2D();
var view2DState = view.getView2DState(); var view2DState = view.getView2DState();
map.requestRenderFrame(); map.render();
ol.interaction.Interaction.rotateWithoutConstraints(map, view, ol.interaction.Interaction.rotateWithoutConstraints(map, view,
view2DState.rotation + rotationDelta, this.anchor_); view2DState.rotation + rotationDelta, this.anchor_);
} }
@@ -147,7 +147,7 @@ ol.interaction.TouchRotate.prototype.handleTouchStart =
this.lastAngle_ = undefined; this.lastAngle_ = undefined;
this.rotating_ = false; this.rotating_ = false;
this.rotationDelta_ = 0.0; this.rotationDelta_ = 0.0;
map.requestRenderFrame(); map.render();
return true; return true;
} else { } else {
return false; return false;

View File

@@ -89,7 +89,7 @@ ol.interaction.TouchZoom.prototype.handleTouchMove =
this.anchor_ = map.getCoordinateFromPixel(centroid); this.anchor_ = map.getCoordinateFromPixel(centroid);
// scale, bypass the resolution constraint // scale, bypass the resolution constraint
map.requestRenderFrame(); map.render();
ol.interaction.Interaction.zoomWithoutConstraints( ol.interaction.Interaction.zoomWithoutConstraints(
map, view, view2DState.resolution * scaleDelta, this.anchor_); map, view, view2DState.resolution * scaleDelta, this.anchor_);
@@ -129,7 +129,7 @@ ol.interaction.TouchZoom.prototype.handleTouchStart =
this.anchor_ = null; this.anchor_ = null;
this.lastDistance_ = undefined; this.lastDistance_ = undefined;
this.lastScaleDelta_ = 1; this.lastScaleDelta_ = 1;
map.requestRenderFrame(); map.render();
return true; return true;
} else { } else {
return false; return false;

View File

@@ -18,6 +18,6 @@
@exportProperty ol.Map.prototype.removeInteraction @exportProperty ol.Map.prototype.removeInteraction
@exportProperty ol.Map.prototype.removeLayer @exportProperty ol.Map.prototype.removeLayer
@exportProperty ol.Map.prototype.removeOverlay @exportProperty ol.Map.prototype.removeOverlay
@exportProperty ol.Map.prototype.render
@exportProperty ol.Map.prototype.renderSync @exportProperty ol.Map.prototype.renderSync
@exportProperty ol.Map.prototype.requestRenderFrame
@exportProperty ol.Map.prototype.updateSize @exportProperty ol.Map.prototype.updateSize

View File

@@ -473,7 +473,7 @@ ol.Map.prototype.addOverlay = function(overlay) {
* @todo stability experimental * @todo stability experimental
*/ */
ol.Map.prototype.beforeRender = function(var_args) { ol.Map.prototype.beforeRender = function(var_args) {
this.requestRenderFrame(); this.render();
Array.prototype.push.apply(this.preRenderFunctions_, arguments); Array.prototype.push.apply(this.preRenderFunctions_, arguments);
}; };
@@ -909,7 +909,7 @@ ol.Map.prototype.handleTargetChanged_ = function() {
* @private * @private
*/ */
ol.Map.prototype.handleTileChange_ = function() { ol.Map.prototype.handleTileChange_ = function() {
this.requestRenderFrame(); this.render();
}; };
@@ -1027,7 +1027,7 @@ ol.Map.prototype.renderSync = function() {
/** /**
* Request that renderFrame_ be called some time in the future. * Request that renderFrame_ be called some time in the future.
*/ */
ol.Map.prototype.requestRenderFrame = function() { ol.Map.prototype.render = function() {
if (this.freezeRenderingCount_ === 0) { if (this.freezeRenderingCount_ === 0) {
if (!this.animationDelay_.isActive()) { if (!this.animationDelay_.isActive()) {
this.animationDelay_.start(); this.animationDelay_.start();
@@ -1198,7 +1198,7 @@ ol.Map.prototype.renderFrame_ = function(time) {
if (!goog.isNull(frameState)) { if (!goog.isNull(frameState)) {
if (frameState.animate) { if (frameState.animate) {
this.requestRenderFrame(); this.render();
} }
Array.prototype.push.apply( Array.prototype.push.apply(
this.postRenderFunctions_, frameState.postRenderFunctions); this.postRenderFunctions_, frameState.postRenderFunctions);

View File

@@ -122,7 +122,7 @@ ol.render.Box.prototype.requestMapRenderFrame_ = function() {
if (!goog.isNull(this.map_) && if (!goog.isNull(this.map_) &&
!goog.isNull(this.startPixel_) && !goog.isNull(this.startPixel_) &&
!goog.isNull(this.endPixel_)) { !goog.isNull(this.endPixel_)) {
this.map_.requestRenderFrame(); this.map_.render();
} }
}; };
@@ -134,7 +134,7 @@ ol.render.Box.prototype.setMap = function(map) {
if (!goog.isNull(this.postComposeListenerKey_)) { if (!goog.isNull(this.postComposeListenerKey_)) {
goog.events.unlistenByKey(this.postComposeListenerKey_); goog.events.unlistenByKey(this.postComposeListenerKey_);
this.postComposeListenerKey_ = null; this.postComposeListenerKey_ = null;
this.map_.requestRenderFrame(); this.map_.render();
this.map_ = null; this.map_ = null;
} }
this.map_ = map; this.map_ = map;

View File

@@ -48,7 +48,7 @@ describe('ol.Map', function() {
}); });
}); });
describe('#requestRenderFrame()', function() { describe('#render()', function() {
var target, map; var target, map;
@@ -78,7 +78,7 @@ describe('ol.Map', function() {
it('results in an postrender event', function(done) { it('results in an postrender event', function(done) {
map.requestRenderFrame(); map.render();
map.on('postrender', function(event) { map.on('postrender', function(event) {
expect(event).to.be.a(ol.MapEvent); expect(event).to.be.a(ol.MapEvent);
var frameState = event.frameState; var frameState = event.frameState;
@@ -92,7 +92,7 @@ describe('ol.Map', function() {
target.style.height = '0px'; target.style.height = '0px';
map.updateSize(); map.updateSize();
map.requestRenderFrame(); map.render();
map.on('postrender', function(event) { map.on('postrender', function(event) {
expect(event).to.be.a(ol.MapEvent); expect(event).to.be.a(ol.MapEvent);
var frameState = event.frameState; var frameState = event.frameState;
@@ -106,7 +106,7 @@ describe('ol.Map', function() {
target.style.width = '0px'; target.style.width = '0px';
map.updateSize(); map.updateSize();
map.requestRenderFrame(); map.render();
map.on('postrender', function(event) { map.on('postrender', function(event) {
expect(event).to.be.a(ol.MapEvent); expect(event).to.be.a(ol.MapEvent);
var frameState = event.frameState; var frameState = event.frameState;