Accept an expression string for rule filter

This commit is contained in:
Tim Schaub
2013-06-17 17:30:44 -06:00
parent 38b784d672
commit a663d8fcae
6 changed files with 30 additions and 22 deletions

View File

@@ -552,7 +552,7 @@
/**
* @typedef {Object} ol.style.RuleOptions
* @property {ol.filter.Filter|undefined} filter Filter.
* @property {ol.expression.Expression|string|undefined} filter Filter.
* @property {Array.<ol.style.Symbolizer>|undefined} symbolizers Symbolizers.
*/

3
src/ol/expression.jsdoc Normal file
View File

@@ -0,0 +1,3 @@
/**
* @namespace ol.expression
*/

View File

@@ -1,7 +1,10 @@
goog.provide('ol.style.Rule');
goog.require('goog.asserts');
goog.require('ol.Feature');
goog.require('ol.filter.Filter');
goog.require('ol.expression');
goog.require('ol.expression.Expression');
goog.require('ol.style.Symbolizer');
@@ -12,11 +15,22 @@ goog.require('ol.style.Symbolizer');
*/
ol.style.Rule = function(options) {
var filter = null;
if (goog.isDef(options.filter)) {
if (goog.isString(options.filter)) {
filter = ol.expression.parse(options.filter);
} else {
goog.asserts.assert(options.filter instanceof ol.expression.Expression);
filter = options.filter;
}
}
/**
* @type {ol.filter.Filter}
* @type {ol.expression.Expression}
* @private
*/
this.filter_ = goog.isDef(options.filter) ? options.filter : null;
this.filter_ = filter;
/**
* @type {Array.<ol.style.Symbolizer>}
@@ -33,7 +47,8 @@ ol.style.Rule = function(options) {
* @return {boolean} Does the rule apply to the feature?
*/
ol.style.Rule.prototype.applies = function(feature) {
return goog.isNull(this.filter_) ? true : this.filter_.applies(feature);
return goog.isNull(this.filter_) ?
true : !!ol.expression.evaluateFeature(this.filter_, feature);
};