From a65a231da3c5737012b40e33073ed87b98c8330a Mon Sep 17 00:00:00 2001 From: Matt Walker Date: Tue, 16 Oct 2012 08:11:59 +0100 Subject: [PATCH] Updated IS_NULL filter to check for strict null. The IS_NULL filter evaluates to true only when the property is null. Updated tests to reflect this change. --- lib/OpenLayers/Filter/Comparison.js | 2 +- tests/Filter/Comparison.html | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/OpenLayers/Filter/Comparison.js b/lib/OpenLayers/Filter/Comparison.js index 68d8cada8f..c38d60f3a5 100644 --- a/lib/OpenLayers/Filter/Comparison.js +++ b/lib/OpenLayers/Filter/Comparison.js @@ -156,7 +156,7 @@ OpenLayers.Filter.Comparison = OpenLayers.Class(OpenLayers.Filter, { result = regexp.test(got); break; case OpenLayers.Filter.Comparison.IS_NULL: - result = (got === null || got === undefined); + result = (got === null); break; } return result; diff --git a/tests/Filter/Comparison.html b/tests/Filter/Comparison.html index e8f9a9c2b0..04e192a348 100644 --- a/tests/Filter/Comparison.html +++ b/tests/Filter/Comparison.html @@ -176,8 +176,8 @@ type: OpenLayers.Filter.Comparison.IS_NULL, property: "prop" }), - context: {prop: undefined}, - expect: true + context: {}, + expect: false }, { filter: new OpenLayers.Filter.Comparison({ type: OpenLayers.Filter.Comparison.IS_NULL, @@ -315,7 +315,7 @@ property: "prop" }), context: new OpenLayers.Feature.Vector(null, {}), - expect: true + expect: false }, { filter: new OpenLayers.Filter.Comparison({ type: OpenLayers.Filter.Comparison.IS_NULL,