Named exports from ol/events/Event

This commit is contained in:
Tim Schaub
2018-02-18 22:50:32 -07:00
parent 4106ed8776
commit a480b0065b
4 changed files with 13 additions and 15 deletions
+2 -3
View File
@@ -18,7 +18,7 @@ import ViewHint from './ViewHint.js';
import {assert} from './asserts.js'; import {assert} from './asserts.js';
import {removeNode} from './dom.js'; import {removeNode} from './dom.js';
import {listen, unlistenByKey, unlisten} from './events.js'; import {listen, unlistenByKey, unlisten} from './events.js';
import Event from './events/Event.js'; import {stopPropagation} from './events/Event.js';
import EventType from './events/EventType.js'; import EventType from './events/EventType.js';
import {createEmpty, clone, createOrUpdateEmpty, equals, getForViewAndSize, isEmpty} from './extent.js'; import {createEmpty, clone, createOrUpdateEmpty, equals, getForViewAndSize, isEmpty} from './extent.js';
import {TRUE} from './functions.js'; import {TRUE} from './functions.js';
@@ -248,8 +248,7 @@ const PluggableMap = function(options) {
EventType.WHEEL EventType.WHEEL
]; ];
for (let i = 0, ii = overlayEvents.length; i < ii; ++i) { for (let i = 0, ii = overlayEvents.length; i < ii; ++i) {
listen(this.overlayContainerStopEvent_, overlayEvents[i], listen(this.overlayContainerStopEvent_, overlayEvents[i], stopPropagation);
Event.stopPropagation);
} }
this.viewport_.appendChild(this.overlayContainerStopEvent_); this.viewport_.appendChild(this.overlayContainerStopEvent_);
+3 -5
View File
@@ -7,7 +7,7 @@ import Control from '../control/Control.js';
import {CLASS_CONTROL, CLASS_UNSELECTABLE} from '../css.js'; import {CLASS_CONTROL, CLASS_UNSELECTABLE} from '../css.js';
import {easeOut} from '../easing.js'; import {easeOut} from '../easing.js';
import {listen} from '../events.js'; import {listen} from '../events.js';
import Event from '../events/Event.js'; import {stopPropagation} from '../events/Event.js';
import EventType from '../events/EventType.js'; import EventType from '../events/EventType.js';
import {clamp} from '../math.js'; import {clamp} from '../math.js';
import PointerEventType from '../pointer/EventType.js'; import PointerEventType from '../pointer/EventType.js';
@@ -130,10 +130,8 @@ const ZoomSlider = function(opt_options) {
listen(this.dragger_, PointerEventType.POINTERUP, listen(this.dragger_, PointerEventType.POINTERUP,
this.handleDraggerEnd_, this); this.handleDraggerEnd_, this);
listen(containerElement, EventType.CLICK, listen(containerElement, EventType.CLICK, this.handleContainerClick_, this);
this.handleContainerClick_, this); listen(thumbElement, EventType.CLICK, stopPropagation);
listen(thumbElement, EventType.CLICK,
Event.stopPropagation);
Control.call(this, { Control.call(this, {
element: containerElement, element: containerElement,
+5 -4
View File
@@ -61,15 +61,16 @@ Event.prototype.preventDefault =
/** /**
* @param {Event|ol.events.Event} evt Event * @param {Event|ol.events.Event} evt Event
*/ */
Event.stopPropagation = function(evt) { export function stopPropagation(evt) {
evt.stopPropagation(); evt.stopPropagation();
}; }
/** /**
* @param {Event|ol.events.Event} evt Event * @param {Event|ol.events.Event} evt Event
*/ */
Event.preventDefault = function(evt) { export function preventDefault(evt) {
evt.preventDefault(); evt.preventDefault();
}; }
export default Event; export default Event;
+3 -3
View File
@@ -1,4 +1,4 @@
import Event from '../../../../src/ol/events/Event.js'; import Event, {preventDefault, stopPropagation} from '../../../../src/ol/events/Event.js';
describe('ol.events.Event', function() { describe('ol.events.Event', function() {
@@ -30,7 +30,7 @@ describe('ol.events.Event', function() {
const event = { const event = {
preventDefault: sinon.spy() preventDefault: sinon.spy()
}; };
Event.preventDefault(event); preventDefault(event);
expect(event.preventDefault.called).to.be(true); expect(event.preventDefault.called).to.be(true);
}); });
}); });
@@ -40,7 +40,7 @@ describe('ol.events.Event', function() {
const event = { const event = {
stopPropagation: sinon.spy() stopPropagation: sinon.spy()
}; };
Event.stopPropagation(event); stopPropagation(event);
expect(event.stopPropagation.called).to.be(true); expect(event.stopPropagation.called).to.be(true);
}); });
}); });