ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Simplifying layer mapping

Browse Source 
By making selectionLayer an object keyed by source layer UIDs,
we save some indexOf lookups.
This commit is contained in:
ahocevar
2013-08-21 18:59:08 +02:00
parent d5c0fdd557
commit a417b75c1f
2 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/spec/ol/control/selectcontrol.test.js
View File

@@ -97,24 +97,24 @@ describe('ol.control.Select', function() {
describe('#select', function() {
it('toggles selection of features', function() {
var layer = select.selectionLayers[0];
select.select([features]);
var layer = select.selectionLayers[goog.getUid(select.layers_[0])];
select.select([features], select.layers_);
expect(goog.object.getCount(layer.featureCache_.idLookup_)).to.be(2);
select.select([features]);
select.select([features], select.layers_);
expect(goog.object.getCount(layer.featureCache_.idLookup_)).to.be(0);
});
it('can append features to an existing selection', function() {
var layer = select.selectionLayers[0];
select.select([[features[0]]]);
select.select([[features[1]]]);
var layer = select.selectionLayers[goog.getUid(select.layers_[0])];
select.select([[features[0]]], select.layers_);
select.select([[features[1]]], select.layers_);
expect(goog.object.getCount(layer.featureCache_.idLookup_)).to.be(2);
});
it('can clear a selection before selecting new features', function() {
var layer = select.selectionLayers[0];
select.select([[features[0]]], true);
select.select([[features[1]]], true);
var layer = select.selectionLayers[goog.getUid(select.layers_[0])];
select.select([[features[0]]], select.layers_, true);
select.select([[features[1]]], select.layers_, true);
expect(goog.object.getCount(layer.featureCache_.idLookup_)).to.be(1);
});