From 235f7c5bd1f983b8ebd43d14abb9d4ba6eb37542 Mon Sep 17 00:00:00 2001 From: Guillaume Beraudo Date: Fri, 21 Nov 2014 13:35:20 +0100 Subject: [PATCH 1/2] Fix lack of `@api doc in webgl Immediate` --- src/ol/render/webgl/webglimmediate.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/ol/render/webgl/webglimmediate.js b/src/ol/render/webgl/webglimmediate.js index c5edd99747..483c341c35 100644 --- a/src/ol/render/webgl/webglimmediate.js +++ b/src/ol/render/webgl/webglimmediate.js @@ -73,6 +73,7 @@ ol.render.webgl.Immediate = function(context, /** * FIXME: empty description for jsdoc + * @api */ ol.render.webgl.Immediate.prototype.flush = function() { /** @type {Array.} */ @@ -91,6 +92,7 @@ ol.render.webgl.Immediate.prototype.flush = function() { /** * @param {number} zIndex Z index. * @param {function(ol.render.webgl.Immediate)} callback Callback. + * @api */ ol.render.webgl.Immediate.prototype.drawAsync = function(zIndex, callback) { var zIndexKey = zIndex.toString(); @@ -105,6 +107,7 @@ ol.render.webgl.Immediate.prototype.drawAsync = function(zIndex, callback) { /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawCircleGeometry = function(circleGeometry, data) { @@ -113,6 +116,7 @@ ol.render.webgl.Immediate.prototype.drawCircleGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawFeature = function(feature, style) { var geometry = feature.getGeometry(); @@ -141,6 +145,7 @@ ol.render.webgl.Immediate.prototype.drawFeature = function(feature, style) { /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawGeometryCollectionGeometry = function(geometryCollectionGeometry, data) { @@ -162,6 +167,7 @@ ol.render.webgl.Immediate.prototype.drawGeometryCollectionGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawPointGeometry = function(pointGeometry, data) { @@ -184,6 +190,7 @@ ol.render.webgl.Immediate.prototype.drawPointGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawLineStringGeometry = function(lineStringGeometry, data) { @@ -192,6 +199,7 @@ ol.render.webgl.Immediate.prototype.drawLineStringGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawMultiLineStringGeometry = function(multiLineStringGeometry, data) { @@ -200,6 +208,7 @@ ol.render.webgl.Immediate.prototype.drawMultiLineStringGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawMultiPointGeometry = function(multiPointGeometry, data) { @@ -222,6 +231,7 @@ ol.render.webgl.Immediate.prototype.drawMultiPointGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawMultiPolygonGeometry = function(multiPolygonGeometry, data) { @@ -230,6 +240,7 @@ ol.render.webgl.Immediate.prototype.drawMultiPolygonGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawPolygonGeometry = function(polygonGeometry, data) { @@ -238,6 +249,7 @@ ol.render.webgl.Immediate.prototype.drawPolygonGeometry = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.drawText = function(flatCoordinates, offset, end, stride, geometry, data) { @@ -246,6 +258,7 @@ ol.render.webgl.Immediate.prototype.drawText = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.setFillStrokeStyle = function(fillStyle, strokeStyle) { @@ -254,6 +267,7 @@ ol.render.webgl.Immediate.prototype.setFillStrokeStyle = /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.setImageStyle = function(imageStyle) { this.imageStyle_ = imageStyle; @@ -262,6 +276,7 @@ ol.render.webgl.Immediate.prototype.setImageStyle = function(imageStyle) { /** * @inheritDoc + * @api */ ol.render.webgl.Immediate.prototype.setTextStyle = function(textStyle) { }; From fe74bd1b2cd9fe3b73dfcbe4ac37058a6a15cbdf Mon Sep 17 00:00:00 2001 From: Guillaume Beraudo Date: Fri, 21 Nov 2014 13:36:09 +0100 Subject: [PATCH 2/2] Add missing call to flush in webgl map renderer --- examples/dynamic-data.js | 2 -- src/ol/renderer/webgl/webglmaprenderer.js | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/dynamic-data.js b/examples/dynamic-data.js index 30ce4df391..793d4ef761 100644 --- a/examples/dynamic-data.js +++ b/examples/dynamic-data.js @@ -74,8 +74,6 @@ map.on('postcompose', function(event) { vectorContext.setImageStyle(headOuterImageStyle); vectorContext.drawMultiPointGeometry(headPoint, null); - vectorContext.flush(); - map.render(); }); map.render(); diff --git a/src/ol/renderer/webgl/webglmaprenderer.js b/src/ol/renderer/webgl/webglmaprenderer.js index 7f7c29e115..a5c6485b42 100644 --- a/src/ol/renderer/webgl/webglmaprenderer.js +++ b/src/ol/renderer/webgl/webglmaprenderer.js @@ -302,6 +302,8 @@ ol.renderer.webgl.Map.prototype.dispatchComposeEvent_ = replayGroup.replay(context, center, resolution, rotation, size, extent, pixelRatio, opacity, brightness, contrast, hue, saturation, {}); } + + vectorContext.flush(); this.replayGroup = replayGroup; } };