diff --git a/src/ol/renderer/webgl/PointsLayer.js b/src/ol/renderer/webgl/PointsLayer.js index b259041c07..bb3ca67fa8 100644 --- a/src/ol/renderer/webgl/PointsLayer.js +++ b/src/ol/renderer/webgl/PointsLayer.js @@ -5,11 +5,7 @@ import BaseVector from '../../layer/BaseVector.js'; import VectorEventType from '../../source/VectorEventType.js'; import ViewHint from '../../ViewHint.js'; import WebGLArrayBuffer from '../../webgl/Buffer.js'; -import WebGLLayerRenderer, { - WebGLWorkerMessageType, - colorDecodeId, - colorEncodeId, -} from './Layer.js'; +import WebGLLayerRenderer from './Layer.js'; import WebGLRenderTarget from '../../webgl/RenderTarget.js'; import {ARRAY_BUFFER, DYNAMIC_DRAW, ELEMENT_ARRAY_BUFFER} from '../../webgl.js'; import {AttributeType, DefaultUniform} from '../../webgl/Helper.js'; @@ -25,6 +21,8 @@ import {buffer, createEmpty, equals, getWidth} from '../../extent.js'; import {create as createWebGLWorker} from '../../worker/webgl.js'; import {getUid} from '../../util.js'; import {listen, unlistenByKey} from '../../events.js'; +import {colorDecodeId, colorEncodeId} from '../../render/webgl/utils.js'; +import {WebGLWorkerMessageType} from '../../render/webgl/constants.js'; /** * @typedef {Object} CustomAttribute A description of a custom attribute to be passed on to the GPU, with a value different @@ -303,7 +301,7 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer { */ function (event) { const received = event.data; - if (received.type === WebGLWorkerMessageType.GENERATE_BUFFERS) { + if (received.type === WebGLWorkerMessageType.GENERATE_POINT_BUFFERS) { const projectionTransform = received.projectionTransform; if (received.hitDetection) { this.hitVerticesBuffer_.fromArrayBuffer(received.vertexBuffer); @@ -637,9 +635,10 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer { } } - /** @type {import('./Layer').WebGLWorkerGenerateBuffersMessage} */ + /** @type {import('../../render/webgl/constants.js').WebGLWorkerGenerateBuffersMessage} */ const message = { - type: WebGLWorkerMessageType.GENERATE_BUFFERS, + id: 0, + type: WebGLWorkerMessageType.GENERATE_POINT_BUFFERS, renderInstructions: this.renderInstructions_.buffer, customAttributesCount: this.customAttributes.length, }; @@ -650,10 +649,11 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer { this.worker_.postMessage(message, [this.renderInstructions_.buffer]); this.renderInstructions_ = null; - /** @type {import('./Layer').WebGLWorkerGenerateBuffersMessage} */ + /** @type {import('../../render/webgl/constants.js').WebGLWorkerGenerateBuffersMessage} */ if (this.hitDetectionEnabled_) { const hitMessage = { - type: WebGLWorkerMessageType.GENERATE_BUFFERS, + id: 0, + type: WebGLWorkerMessageType.GENERATE_POINT_BUFFERS, renderInstructions: this.hitRenderInstructions_.buffer, customAttributesCount: 5 + this.customAttributes.length, }; diff --git a/test/browser/spec/ol/renderer/webgl/PointsLayer.test.js b/test/browser/spec/ol/renderer/webgl/PointsLayer.test.js index 62fa1939ac..bd89302aa6 100644 --- a/test/browser/spec/ol/renderer/webgl/PointsLayer.test.js +++ b/test/browser/spec/ol/renderer/webgl/PointsLayer.test.js @@ -8,7 +8,7 @@ import View from '../../../../../../src/ol/View.js'; import ViewHint from '../../../../../../src/ol/ViewHint.js'; import WebGLPointsLayer from '../../../../../../src/ol/layer/WebGLPoints.js'; import WebGLPointsLayerRenderer from '../../../../../../src/ol/renderer/webgl/PointsLayer.js'; -import {WebGLWorkerMessageType} from '../../../../../../src/ol/renderer/webgl/Layer.js'; +import {WebGLWorkerMessageType} from '../../../../../../src/ol/render/webgl/constants.js'; import { compose as composeTransform, create as createTransform, @@ -156,7 +156,7 @@ describe('ol/renderer/webgl/PointsLayer', function () { const attributePerVertex = 3; renderer.worker_.addEventListener('message', function (event) { - if (event.data.type !== WebGLWorkerMessageType.GENERATE_BUFFERS) { + if (event.data.type !== WebGLWorkerMessageType.GENERATE_POINT_BUFFERS) { return; } expect(renderer.verticesBuffer_.getArray().length).to.eql( @@ -192,7 +192,7 @@ describe('ol/renderer/webgl/PointsLayer', function () { const attributePerVertex = 8; renderer.worker_.addEventListener('message', function (event) { - if (event.data.type !== WebGLWorkerMessageType.GENERATE_BUFFERS) { + if (event.data.type !== WebGLWorkerMessageType.GENERATE_POINT_BUFFERS) { return; } if (!renderer.hitVerticesBuffer_.getArray()) { @@ -231,7 +231,7 @@ describe('ol/renderer/webgl/PointsLayer', function () { renderer.prepareFrame(frameState); renderer.worker_.addEventListener('message', function (event) { - if (event.data.type !== WebGLWorkerMessageType.GENERATE_BUFFERS) { + if (event.data.type !== WebGLWorkerMessageType.GENERATE_POINT_BUFFERS) { return; } const attributePerVertex = 3; @@ -627,14 +627,14 @@ describe('ol/renderer/webgl/PointsLayer', function () { beforeEach(function () { source = new VectorSource({ features: new GeoJSON().readFeatures({ - 'type': 'FeatureCollection', - 'features': [ + type: 'FeatureCollection', + features: [ { - 'type': 'Feature', - 'properties': {}, - 'geometry': { - 'type': 'Point', - 'coordinates': [13, 52], + type: 'Feature', + properties: {}, + geometry: { + type: 'Point', + coordinates: [13, 52], }, }, ],