From a13cacdde9186a7eed31c21060db31e2c0ba54cb Mon Sep 17 00:00:00 2001 From: euzuro Date: Wed, 21 Nov 2007 18:50:55 +0000 Subject: [PATCH] protect stopObserving() from trying to remove nonexistant events. thx for review, cr5 (Closes #1151) git-svn-id: http://svn.openlayers.org/trunk/openlayers@5241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf --- lib/OpenLayers/Events.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/OpenLayers/Events.js b/lib/OpenLayers/Events.js index ee33c933ea..4214a95c20 100644 --- a/lib/OpenLayers/Events.js +++ b/lib/OpenLayers/Events.js @@ -295,10 +295,12 @@ OpenLayers.Event = { } //actually remove the event listener from browser - if (element.removeEventListener) { - element.removeEventListener(name, observer, useCapture); - } else if (element && element.detachEvent) { - element.detachEvent('on' + name, observer); + if (foundEntry) { + if (element.removeEventListener) { + element.removeEventListener(name, observer, useCapture); + } else if (element && element.detachEvent) { + element.detachEvent('on' + name, observer); + } } return foundEntry; },