From a0d79fe98cc125f59006a162cf572139103393d9 Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Wed, 29 Jan 2014 20:36:01 +0100 Subject: [PATCH] Improve type checking in ol.events.condition.targetNotEditable --- src/ol/events/condition.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ol/events/condition.js b/src/ol/events/condition.js index 7171cbde36..dbedefbfdc 100644 --- a/src/ol/events/condition.js +++ b/src/ol/events/condition.js @@ -1,6 +1,7 @@ goog.provide('ol.events.ConditionType'); goog.provide('ol.events.condition'); +goog.require('goog.asserts'); goog.require('goog.dom.TagName'); goog.require('goog.functions'); goog.require('ol.MapBrowserEvent.EventType'); @@ -107,8 +108,9 @@ ol.events.condition.shiftKeyOnly = function(mapBrowserEvent) { * @todo stability experimental */ ol.events.condition.targetNotEditable = function(mapBrowserEvent) { - var browserEvent = mapBrowserEvent.browserEvent; - var tagName = browserEvent.target.tagName; + var target = mapBrowserEvent.browserEvent.target; + goog.asserts.assertInstanceof(target, Element); + var tagName = target.tagName; return ( tagName !== goog.dom.TagName.INPUT && tagName !== goog.dom.TagName.SELECT &&