ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove 'valueAsNumber' property from ol.dom.Input

Browse Source 
Use bindTo.transform functions instead
This commit is contained in:
Frederic Junod
2013-10-30 15:21:29 +01:00
parent bba1de2679
commit a0bea641d1
3 changed files with 16 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/ol/dom/input.js
View File

@@ -11,7 +11,6 @@ goog.require('ol.Object');
*/
ol.dom.InputProperty = {
VALUE: 'value',
VALUE_AS_NUMBER: 'valueAsNumber',
CHECKED: 'checked'
};
@@ -50,9 +49,6 @@ ol.dom.Input = function(target) {
goog.events.listen(this,
ol.Object.getChangeEventType(ol.dom.InputProperty.VALUE),
this.handleValueChanged_, false, this);
goog.events.listen(this,
ol.Object.getChangeEventType(ol.dom.InputProperty.VALUE_AS_NUMBER),
this.handleValueAsNumberChanged_, false, this);
goog.events.listen(this,
ol.Object.getChangeEventType(ol.dom.InputProperty.CHECKED),
this.handleCheckedChanged_, false, this);
@@ -88,20 +84,6 @@ goog.exportProperty(
ol.dom.Input.prototype.getValue);
/**
* Get the value of the input as a number.
* @return {number|null|undefined} input value as number.
* @todo stability experimental
*/
ol.dom.Input.prototype.getValueAsNumber = function() {
return /** @type {number} */ (this.get(ol.dom.InputProperty.VALUE_AS_NUMBER));
};
goog.exportProperty(
ol.dom.Input.prototype,
'getValueAsNumber',
ol.dom.Input.prototype.getValueAsNumber);
/**
* Sets the value of the input.
* @param {string} value Value.
@@ -116,20 +98,6 @@ goog.exportProperty(
ol.dom.Input.prototype.setValue);
/**
* Sets the number value of the input.
* @param {number} value Number value.
* @todo stability experimental
*/
ol.dom.Input.prototype.setValueAsNumber = function(value) {
this.set(ol.dom.InputProperty.VALUE_AS_NUMBER, value);
};
goog.exportProperty(
ol.dom.Input.prototype,
'setValueAsNumber',
ol.dom.Input.prototype.setValueAsNumber);
/**
* Set whether or not a checkbox is checked.
* @param {boolean} checked Checked.
@@ -152,10 +120,6 @@ ol.dom.Input.prototype.handleInputChanged_ = function() {
this.setChecked(this.target_.checked);
} else {
this.setValue(this.target_.value);
var number = this.target_.valueAsNumber;
if (goog.isDef(number) && !isNaN(number)) {
this.setValueAsNumber(number);
}
}
};
@@ -174,12 +138,3 @@ ol.dom.Input.prototype.handleCheckedChanged_ = function() {
ol.dom.Input.prototype.handleValueChanged_ = function() {
this.target_.value = this.getValue();
};
/**
* @private
*/
ol.dom.Input.prototype.handleValueAsNumberChanged_ = function() {
// firefox raises an exception if this.target_.valueAsNumber is set instead
this.target_.value = this.getValueAsNumber();
};