From 9eb4816b27916334b4eface33b4c5c983c5fd999 Mon Sep 17 00:00:00 2001 From: Edward Nash Date: Tue, 22 Oct 2019 09:14:07 +0200 Subject: [PATCH] Fix property name collision target_ with Control * As described in #10158, Control uses the property target_ for a custom parent HTMLElement, leading to Events on the Control being dispatched with that as the target and not the Control itself. * Solved by renaming the target_ property on Target to eventTarget_ --- src/ol/events/Target.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ol/events/Target.js b/src/ol/events/Target.js index 04c65b846a..797f72610a 100644 --- a/src/ol/events/Target.js +++ b/src/ol/events/Target.js @@ -40,7 +40,7 @@ class Target extends Disposable { * @private * @type {*} */ - this.target_ = opt_target; + this.eventTarget_ = opt_target; /** * @private @@ -96,7 +96,7 @@ class Target extends Disposable { const evt = typeof event === 'string' ? new Event(event) : event; const type = evt.type; if (!evt.target) { - evt.target = this.target_ || this; + evt.target = this.eventTarget_ || this; } const listeners = this.listeners_[type]; let propagate;