From 9cc7cca447fc4690d26a76e4488b6196909890b2 Mon Sep 17 00:00:00 2001
From: oterral <olivier.terral@swisstopo.ch>
Date: Fri, 17 Nov 2017 08:59:23 +0100
Subject: [PATCH] Fix #6835: doesn't break if Constraint does not exist

---
 src/ol/source/wmts.js            | 31 ++++++++++++++++++-------------
 src/ol/tilegrid/wmts.js          |  3 +--
 test/spec/ol/source/wmts.test.js | 29 ++++++++++++++++++++++++++++-
 3 files changed, 47 insertions(+), 16 deletions(-)

diff --git a/src/ol/source/wmts.js b/src/ol/source/wmts.js
index e6102f5260..0611f5505c 100644
--- a/src/ol/source/wmts.js
+++ b/src/ol/source/wmts.js
@@ -419,21 +419,26 @@ ol.source.WMTS.optionsFromCapabilities = function(wmtsCap, config) {
     var gets = wmtsCap['OperationsMetadata']['GetTile']['DCP']['HTTP']['Get'];
 
     for (var i = 0, ii = gets.length; i < ii; ++i) {
-      var constraint = ol.array.find(gets[i]['Constraint'], function(element) {
-        return element['name'] == 'GetEncoding';
-      });
-      var encodings = constraint['AllowedValues']['Value'];
+      if (gets[i]['Constraint']) {
+        var constraint = ol.array.find(gets[i]['Constraint'], function(element) {
+          return element['name'] == 'GetEncoding';
+        });
+        var encodings = constraint['AllowedValues']['Value'];
 
-      if (requestEncoding === '') {
-        // requestEncoding not provided, use the first encoding from the list
-        requestEncoding = encodings[0];
-      }
-      if (requestEncoding === ol.source.WMTSRequestEncoding.KVP) {
-        if (ol.array.includes(encodings, ol.source.WMTSRequestEncoding.KVP)) {
-          urls.push(/** @type {string} */ (gets[i]['href']));
+        if (requestEncoding === '') {
+          // requestEncoding not provided, use the first encoding from the list
+          requestEncoding = encodings[0];
         }
-      } else {
-        break;
+        if (requestEncoding === ol.source.WMTSRequestEncoding.KVP) {
+          if (ol.array.includes(encodings, ol.source.WMTSRequestEncoding.KVP)) {
+            urls.push(/** @type {string} */ (gets[i]['href']));
+          }
+        } else {
+          break;
+        }
+      } else if (gets[i]['href']) {
+        requestEncoding = ol.source.WMTSRequestEncoding.KVP;
+        urls.push(/** @type {string} */ (gets[i]['href']));
       }
     }
   }
diff --git a/src/ol/tilegrid/wmts.js b/src/ol/tilegrid/wmts.js
index 58faa910e6..c67ff01f18 100644
--- a/src/ol/tilegrid/wmts.js
+++ b/src/ol/tilegrid/wmts.js
@@ -92,9 +92,8 @@ ol.tilegrid.WMTS.createFromCapabilitiesMatrixSet = function(matrixSet, opt_exten
   var tileWidthPropName = 'TileWidth';
   var tileHeightPropName = 'TileHeight';
 
-  var projection;
   var code = matrixSet[supportedCRSPropName];
-  projection = ol.proj.get(code.replace(/urn:ogc:def:crs:(\w+):(.*:)?(\w+)$/, '$1:$3')) ||
+  var projection = ol.proj.get(code.replace(/urn:ogc:def:crs:(\w+):(.*:)?(\w+)$/, '$1:$3')) ||
       ol.proj.get(code);
   var metersPerUnit = projection.getMetersPerUnit();
   // swap origin x and y coordinates if axis orientation is lat/long
diff --git a/test/spec/ol/source/wmts.test.js b/test/spec/ol/source/wmts.test.js
index caaf6dd0ae..e2674a29d4 100644
--- a/test/spec/ol/source/wmts.test.js
+++ b/test/spec/ol/source/wmts.test.js
@@ -11,10 +11,11 @@ describe('ol.source.WMTS', function() {
 
   describe('when creating options from capabilities', function() {
     var parser = new ol.format.WMTSCapabilities();
-    var capabilities;
+    var capabilities, content;
     before(function(done) {
       afterLoadText('spec/ol/format/wmts/ogcsample.xml', function(xml) {
         try {
+          content = xml;
           capabilities = parser.read(xml);
         } catch (e) {
           done(e);
@@ -149,6 +150,32 @@ describe('ol.source.WMTS', function() {
       expect(options.matrixSet).to.be.eql('BigWorldPixel');
       expect(options.projection.getCode()).to.be.eql('urn:ogc:def:crs:OGC:1.3:CRS84');
     });
+
+    it('doesn\'t fail if the GetCap doesn\'t contains Constraint tags', function() {
+      var tmpXml = content.replace(/<ows:Constraint[\s\S]*?<\/ows:Constraint>/g, '');
+      var tmpCapabilities = parser.read(tmpXml);
+      expect(tmpCapabilities['OperationsMetadata']['GetTile']['DCP']['HTTP']['Get'][0]['Constraint']).to.be(undefined);
+      var options = ol.source.WMTS.optionsFromCapabilities(tmpCapabilities,
+          {layer: 'BlueMarbleNextGeneration', matrixSet: 'google3857'});
+      expect(options.layer).to.be.eql('BlueMarbleNextGeneration');
+      expect(options.matrixSet).to.be.eql('google3857');
+    });
+
+    it('set KVP as default request encoding if the GetCap doesn\'t contains Constraint and ResourceUrl tags', function() {
+      var tmpXml = content.replace(/<ows:Constraint[\s\S]*?<\/ows:Constraint>/g, '');
+      tmpXml = tmpXml.replace(/<ResourceURL[\s\S]*?"\/>/g, '');
+
+      var tmpCapabilities = parser.read(tmpXml);
+      expect(tmpCapabilities['OperationsMetadata']['GetTile']['DCP']['HTTP']['Get'][0]['Constraint']).to.be(undefined);
+      expect(tmpCapabilities['Contents']['Layer'][0]['ResourceURL']).to.be(undefined);
+      var options = ol.source.WMTS.optionsFromCapabilities(tmpCapabilities,
+          {layer: 'BlueMarbleNextGeneration', matrixSet: 'google3857'});
+      expect(options.layer).to.be.eql('BlueMarbleNextGeneration');
+      expect(options.matrixSet).to.be.eql('google3857');
+      expect(options.urls).to.be.an('array');
+      expect(options.urls).to.have.length(1);
+      expect(options.urls[0]).to.be.eql('http://www.maps.bob/cgi-bin/MiraMon5_0.cgi?');
+    });
   });
 
   describe('when creating tileUrlFunction', function() {