From 9c594bc9979ab3bdfe6b60c656e80e9148230208 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Wed, 2 Mar 2016 13:22:33 -0700 Subject: [PATCH] Use where function in MVT tests --- test/spec/ol/format/mvtformat.test.js | 129 +++++++++++++------------- test/test-extensions.js | 1 + 2 files changed, 65 insertions(+), 65 deletions(-) diff --git a/test/spec/ol/format/mvtformat.test.js b/test/spec/ol/format/mvtformat.test.js index 4451445165..9f4c8b0015 100644 --- a/test/spec/ol/format/mvtformat.test.js +++ b/test/spec/ol/format/mvtformat.test.js @@ -1,75 +1,74 @@ goog.provide('ol.test.format.MVT'); -(typeof ArrayBuffer == 'function' ? describe : xdescribe)('ol.format.MVT', - function() { +where('ArrayBuffer').describe('ol.format.MVT', function() { - var data; - beforeEach(function(done) { - var xhr = new XMLHttpRequest(); - xhr.open('GET', 'spec/ol/data/14-8938-5680.vector.pbf'); - xhr.responseType = 'arraybuffer'; - xhr.onload = function() { - data = xhr.response; - done(); - }; - xhr.send(); - }); + var data; + beforeEach(function(done) { + var xhr = new XMLHttpRequest(); + xhr.open('GET', 'spec/ol/data/14-8938-5680.vector.pbf'); + xhr.responseType = 'arraybuffer'; + xhr.onload = function() { + data = xhr.response; + done(); + }; + xhr.send(); + }); - describe('#readFeatures', function() { - - it('uses ol.render.Feature as feature class by default', function() { - var format = new ol.format.MVT({layers: ['water']}); - var features = format.readFeatures(data); - expect(features[0]).to.be.a(ol.render.Feature); - }); - - it('parses only specified layers', function() { - var format = new ol.format.MVT({layers: ['water']}); - var features = format.readFeatures(data); - expect(features.length).to.be(10); - }); - - it('parses geometries correctly', function() { - var format = new ol.format.MVT({ - featureClass: ol.Feature, - layers: ['poi_label'] - }); - var pbf = new ol.ext.pbf(data); - var tile = new ol.ext.vectortile.VectorTile(pbf); - var geometry, rawGeometry; - - rawGeometry = tile.layers['poi_label'].feature(0).loadGeometry(); - geometry = format.readFeatures(data)[0] - .getGeometry(); - expect(geometry.getType()).to.be('Point'); - expect(geometry.getCoordinates()) - .to.eql([rawGeometry[0][0].x, rawGeometry[0][0].y]); - - rawGeometry = tile.layers['water'].feature(0).loadGeometry(); - format.setLayers(['water']); - geometry = format.readFeatures(data)[0] - .getGeometry(); - expect(geometry.getType()).to.be('Polygon'); - expect(rawGeometry[0].length) - .to.equal(geometry.getCoordinates()[0].length); - expect(geometry.getCoordinates()[0][0]) - .to.eql([rawGeometry[0][0].x, rawGeometry[0][0].y]); - - rawGeometry = tile.layers['barrier_line'].feature(0).loadGeometry(); - format.setLayers(['barrier_line']); - geometry = format.readFeatures(data)[0] - .getGeometry(); - expect(geometry.getType()).to.be('MultiLineString'); - expect(rawGeometry[1].length) - .to.equal(geometry.getCoordinates()[1].length); - expect(geometry.getCoordinates()[1][0]) - .to.eql([rawGeometry[1][0].x, rawGeometry[1][0].y]); - }); - - }); + describe('#readFeatures', function() { + it('uses ol.render.Feature as feature class by default', function() { + var format = new ol.format.MVT({layers: ['water']}); + var features = format.readFeatures(data); + expect(features[0]).to.be.a(ol.render.Feature); }); + it('parses only specified layers', function() { + var format = new ol.format.MVT({layers: ['water']}); + var features = format.readFeatures(data); + expect(features.length).to.be(10); + }); + + it('parses geometries correctly', function() { + var format = new ol.format.MVT({ + featureClass: ol.Feature, + layers: ['poi_label'] + }); + var pbf = new ol.ext.pbf(data); + var tile = new ol.ext.vectortile.VectorTile(pbf); + var geometry, rawGeometry; + + rawGeometry = tile.layers['poi_label'].feature(0).loadGeometry(); + geometry = format.readFeatures(data)[0] + .getGeometry(); + expect(geometry.getType()).to.be('Point'); + expect(geometry.getCoordinates()) + .to.eql([rawGeometry[0][0].x, rawGeometry[0][0].y]); + + rawGeometry = tile.layers['water'].feature(0).loadGeometry(); + format.setLayers(['water']); + geometry = format.readFeatures(data)[0] + .getGeometry(); + expect(geometry.getType()).to.be('Polygon'); + expect(rawGeometry[0].length) + .to.equal(geometry.getCoordinates()[0].length); + expect(geometry.getCoordinates()[0][0]) + .to.eql([rawGeometry[0][0].x, rawGeometry[0][0].y]); + + rawGeometry = tile.layers['barrier_line'].feature(0).loadGeometry(); + format.setLayers(['barrier_line']); + geometry = format.readFeatures(data)[0] + .getGeometry(); + expect(geometry.getType()).to.be('MultiLineString'); + expect(rawGeometry[1].length) + .to.equal(geometry.getCoordinates()[1].length); + expect(geometry.getCoordinates()[1][0]) + .to.eql([rawGeometry[1][0].x, rawGeometry[1][0].y]); + }); + + }); + +}); + goog.require('ol.Feature'); goog.require('ol.ext.pbf'); diff --git a/test/test-extensions.js b/test/test-extensions.js index 0fe24c08a3..efa5f87a1a 100644 --- a/test/test-extensions.js +++ b/test/test-extensions.js @@ -459,6 +459,7 @@ }; var features = { + ArrayBuffer: typeof ArrayBuffer === 'function', Uint8ClampedArray: ('Uint8ClampedArray' in global) };