ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove getter for down_

Browse Source
This commit is contained in:
tsauerwein
2015-01-30 09:23:44 +01:00
parent 9cc8390dfd
commit 9a841583db
2 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/ol/mapbrowserevent.js
View File

@@ -64,6 +64,9 @@ ol.MapBrowserEvent = function(type, map, browserEvent, opt_dragging,
this.coordinate = map.getCoordinateFromPixel(this.pixel);
/**
* Indicates if the map is currently being dragged. Only set for
* `POINTERDRAG` and `POINTERMOVE` events. Default is `false`.
*
* @type {boolean}
* @api stable
*/
@@ -173,6 +176,8 @@ ol.MapBrowserEventHandler = function(map) {
}
/**
* The most recent "down" type event (or null if none have occurred).
* Set on pointerdown.
* @type {ol.pointer.PointerEvent}
* @private
*/
@@ -233,16 +238,6 @@ ol.MapBrowserEventHandler = function(map) {
goog.inherits(ol.MapBrowserEventHandler, goog.events.EventTarget);
/**
* Get the last "down" type event. This will be set on pointerdown.
* @return {ol.pointer.PointerEvent} The most recent "down" type event (or null
* if none have occurred).
*/
ol.MapBrowserEventHandler.prototype.getDown = function() {
return this.down_;
};
/**
* @param {goog.events.BrowserEvent} browserEvent Pointer event.
* @private

10
test/spec/ol/mapbrowserevent.test.js
View File

@@ -96,22 +96,22 @@ describe('ol.MapBrowserEventHandler', function() {
});
describe('#getDown()', function() {
describe('#down_', function() {
var handler;
beforeEach(function() {
handler = new ol.MapBrowserEventHandler(new ol.Map({}));
});
it('returns null if no "down" type event has been handled', function() {
expect(handler.getDown()).to.be(null);
it('is null if no "down" type event has been handled', function() {
expect(handler.down_).to.be(null);
});
it('returns an event after handlePointerDown_ has been called', function() {
it('is an event after handlePointerDown_ has been called', function() {
var event = new ol.pointer.PointerEvent('pointerdown',
new goog.events.BrowserEvent({}));
handler.handlePointerDown_(event);
expect(handler.getDown()).to.be(event);
expect(handler.down_).to.be(event);
});
});