From 9a2363d06b139f2516202663e5363c68d0a3f317 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89ric=20Lemoine?= <eric.lemoine@camptocamp.com>
Date: Mon, 21 Jun 2010 08:08:13 +0000
Subject: [PATCH] Format.Filter.v1 may fail to read LowerBoundary and
 upperBoundary, r=bartvde

git-svn-id: http://svn.openlayers.org/trunk/openlayers@10420 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
---
 lib/OpenLayers/Format/Filter/v1.js |  2 +-
 tests/Format/Filter/v1.html        | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/lib/OpenLayers/Format/Filter/v1.js b/lib/OpenLayers/Format/Filter/v1.js
index 5556c1662b..d0eb67ce93 100644
--- a/lib/OpenLayers/Format/Filter/v1.js
+++ b/lib/OpenLayers/Format/Filter/v1.js
@@ -227,7 +227,7 @@ OpenLayers.Format.Filter.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
         var obj = {};
         this.readChildNodes(node, obj);
         var value = obj.value;
-        if(!value) {
+        if(value === undefined) {
             value = this.getChildValue(node);
         }
         return value;
diff --git a/tests/Format/Filter/v1.html b/tests/Format/Filter/v1.html
index 5471717387..a596521213 100644
--- a/tests/Format/Filter/v1.html
+++ b/tests/Format/Filter/v1.html
@@ -3,6 +3,35 @@
     <script src="../../../lib/OpenLayers.js"></script>
     <script type="text/javascript">
     
+    function test_PropertyIsBetween(t) {
+
+        t.plan(3);
+
+        var test_xml =
+            '<ogc:Filter xmlns:ogc="http://www.opengis.net/ogc">' +
+                '<ogc:PropertyIsBetween>' +
+                    '<ogc:PropertyName>number</ogc:PropertyName>' +
+                    '<ogc:LowerBoundary>' +
+                        '<ogc:Literal>0</ogc:Literal>' +
+                    '</ogc:LowerBoundary>' +
+                    '<ogc:UpperBoundary>' +
+                        '<ogc:Literal>100</ogc:Literal>' +
+                    '</ogc:UpperBoundary>' +
+                '</ogc:PropertyIsBetween>' +
+            '</ogc:Filter>';
+
+        var parser = new OpenLayers.Format.Filter.v1();
+        var xml = new OpenLayers.Format.XML();
+        var filter = parser.read(xml.read(test_xml).documentElement);
+
+        t.eq(filter.type, OpenLayers.Filter.Comparison.BETWEEN,
+             "read correct type");
+        t.eq(filter.lowerBoundary, 0,
+             "record correct lower boundary value");
+        t.eq(filter.upperBoundary, 100,
+             "record correct upper boundary value");
+    }
+
 
     function test_Intersects(t) {