fixes after rebase

This commit is contained in:
Olivier Guyot
2022-07-15 22:49:54 +02:00
parent 5d21e548ae
commit 998dc82592
4 changed files with 19 additions and 23 deletions

View File

@@ -1,7 +1,6 @@
/** /**
* @module ol/render/webgl/BatchRenderer * @module ol/render/webgl/BatchRenderer
*/ */
import GeometryType from '../../geom/GeometryType.js';
import {WebGLWorkerMessageType} from './constants.js'; import {WebGLWorkerMessageType} from './constants.js';
import {abstract} from '../../util.js'; import {abstract} from '../../util.js';
import { import {
@@ -72,7 +71,7 @@ class AbstractBatchRenderer {
* Note: this is a costly operation. * Note: this is a costly operation.
* @param {import("./MixedGeometryBatch.js").GeometryBatch} batch Geometry batch * @param {import("./MixedGeometryBatch.js").GeometryBatch} batch Geometry batch
* @param {import("../../PluggableMap").FrameState} frameState Frame state. * @param {import("../../PluggableMap").FrameState} frameState Frame state.
* @param {import("../../geom/GeometryType.js").default} geometryType Geometry type * @param {import("../../geom/Geometry.js").Type} geometryType Geometry type
* @param {function(): void} callback Function called once the render buffers are updated * @param {function(): void} callback Function called once the render buffers are updated
*/ */
rebuild(batch, frameState, geometryType, callback) { rebuild(batch, frameState, geometryType, callback) {
@@ -123,7 +122,7 @@ class AbstractBatchRenderer {
* Rebuild internal webgl buffers for rendering based on the current rendering instructions; * Rebuild internal webgl buffers for rendering based on the current rendering instructions;
* This is asynchronous: webgl buffers wil _not_ be updated right away * This is asynchronous: webgl buffers wil _not_ be updated right away
* @param {import("./MixedGeometryBatch.js").GeometryBatch} batch Geometry batch * @param {import("./MixedGeometryBatch.js").GeometryBatch} batch Geometry batch
* @param {import("../../geom/GeometryType.js").default} geometryType Geometry type * @param {import("../../geom/Geometry.js").Type} geometryType Geometry type
* @param {function(): void} callback Function called once the render buffers are updated * @param {function(): void} callback Function called once the render buffers are updated
* @private * @private
*/ */
@@ -132,13 +131,13 @@ class AbstractBatchRenderer {
let messageType; let messageType;
switch (geometryType) { switch (geometryType) {
case GeometryType.POLYGON: case 'Polygon':
messageType = WebGLWorkerMessageType.GENERATE_POLYGON_BUFFERS; messageType = WebGLWorkerMessageType.GENERATE_POLYGON_BUFFERS;
break; break;
case GeometryType.POINT: case 'Point':
messageType = WebGLWorkerMessageType.GENERATE_POINT_BUFFERS; messageType = WebGLWorkerMessageType.GENERATE_POINT_BUFFERS;
break; break;
case GeometryType.LINE_STRING: case 'LineString':
messageType = WebGLWorkerMessageType.GENERATE_LINE_STRING_BUFFERS; messageType = WebGLWorkerMessageType.GENERATE_LINE_STRING_BUFFERS;
break; break;
default: default:

View File

@@ -1,7 +1,6 @@
/** /**
* @module ol/render/webgl/MixedGeometryBatch * @module ol/render/webgl/MixedGeometryBatch
*/ */
import GeometryType from '../../geom/GeometryType.js';
import WebGLArrayBuffer from '../../webgl/Buffer.js'; import WebGLArrayBuffer from '../../webgl/Buffer.js';
import {ARRAY_BUFFER, DYNAMIC_DRAW, ELEMENT_ARRAY_BUFFER} from '../../webgl.js'; import {ARRAY_BUFFER, DYNAMIC_DRAW, ELEMENT_ARRAY_BUFFER} from '../../webgl.js';
import {create as createTransform} from '../../transform.js'; import {create as createTransform} from '../../transform.js';
@@ -261,27 +260,27 @@ class MixedGeometryBatch {
let verticesCount; let verticesCount;
let batchEntry; let batchEntry;
switch (type) { switch (type) {
case GeometryType.GEOMETRY_COLLECTION: case 'GeometryCollection':
/** @type {import("../../geom").GeometryCollection} */ (geometry) /** @type {import("../../geom").GeometryCollection} */ (geometry)
.getGeometries() .getGeometries()
.map((geom) => this.addGeometry_(geom, feature)); .map((geom) => this.addGeometry_(geom, feature));
break; break;
case GeometryType.MULTI_POLYGON: case 'MultiPolygon':
/** @type {import("../../geom").MultiPolygon} */ (geometry) /** @type {import("../../geom").MultiPolygon} */ (geometry)
.getPolygons() .getPolygons()
.map((polygon) => this.addGeometry_(polygon, feature)); .map((polygon) => this.addGeometry_(polygon, feature));
break; break;
case GeometryType.MULTI_LINE_STRING: case 'MultiLineString':
/** @type {import("../../geom").MultiLineString} */ (geometry) /** @type {import("../../geom").MultiLineString} */ (geometry)
.getLineStrings() .getLineStrings()
.map((line) => this.addGeometry_(line, feature)); .map((line) => this.addGeometry_(line, feature));
break; break;
case GeometryType.MULTI_POINT: case 'MultiPoint':
/** @type {import("../../geom").MultiPoint} */ (geometry) /** @type {import("../../geom").MultiPoint} */ (geometry)
.getPoints() .getPoints()
.map((point) => this.addGeometry_(point, feature)); .map((point) => this.addGeometry_(point, feature));
break; break;
case GeometryType.POLYGON: case 'Polygon':
const polygonGeom = /** @type {import("../../geom").Polygon} */ ( const polygonGeom = /** @type {import("../../geom").Polygon} */ (
geometry geometry
); );
@@ -305,15 +304,15 @@ class MixedGeometryBatch {
.getLinearRings() .getLinearRings()
.map((ring) => this.addGeometry_(ring, feature)); .map((ring) => this.addGeometry_(ring, feature));
break; break;
case GeometryType.POINT: case 'Point':
const pointGeom = /** @type {import("../../geom").Point} */ (geometry); const pointGeom = /** @type {import("../../geom").Point} */ (geometry);
batchEntry = this.addFeatureEntryInPointBatch_(feature); batchEntry = this.addFeatureEntryInPointBatch_(feature);
flatCoords = pointGeom.getFlatCoordinates(); flatCoords = pointGeom.getFlatCoordinates();
this.pointBatch.geometriesCount++; this.pointBatch.geometriesCount++;
batchEntry.flatCoordss.push(flatCoords); batchEntry.flatCoordss.push(flatCoords);
break; break;
case GeometryType.LINE_STRING: case 'LineString':
case GeometryType.LINEAR_RING: case 'LinearRing':
const lineGeom = /** @type {import("../../geom").LineString} */ ( const lineGeom = /** @type {import("../../geom").LineString} */ (
geometry geometry
); );

View File

@@ -2,7 +2,6 @@
* @module ol/renderer/webgl/VectorLayer * @module ol/renderer/webgl/VectorLayer
*/ */
import BaseVector from '../../layer/BaseVector.js'; import BaseVector from '../../layer/BaseVector.js';
import GeometryType from '../../geom/GeometryType.js';
import LineStringBatchRenderer from '../../render/webgl/LineStringBatchRenderer.js'; import LineStringBatchRenderer from '../../render/webgl/LineStringBatchRenderer.js';
import MixedGeometryBatch from '../../render/webgl/MixedGeometryBatch.js'; import MixedGeometryBatch from '../../render/webgl/MixedGeometryBatch.js';
import PointBatchRenderer from '../../render/webgl/PointBatchRenderer.js'; import PointBatchRenderer from '../../render/webgl/PointBatchRenderer.js';
@@ -345,19 +344,19 @@ class WebGLVectorLayerRenderer extends WebGLLayerRenderer {
this.polygonRenderer_.rebuild( this.polygonRenderer_.rebuild(
this.batch_.polygonBatch, this.batch_.polygonBatch,
frameState, frameState,
GeometryType.POLYGON, 'Polygon',
rebuildCb rebuildCb
); );
this.lineStringRenderer_.rebuild( this.lineStringRenderer_.rebuild(
this.batch_.lineStringBatch, this.batch_.lineStringBatch,
frameState, frameState,
GeometryType.LINE_STRING, 'LineString',
rebuildCb rebuildCb
); );
this.pointRenderer_.rebuild( this.pointRenderer_.rebuild(
this.batch_.pointBatch, this.batch_.pointBatch,
frameState, frameState,
GeometryType.POINT, 'Point',
rebuildCb rebuildCb
); );
this.previousExtent_ = frameState.extent.slice(); this.previousExtent_ = frameState.extent.slice();

View File

@@ -1,5 +1,4 @@
import Feature from '../../../../../../src/ol/Feature.js'; import Feature from '../../../../../../src/ol/Feature.js';
import GeometryType from '../../../../../../src/ol/geom/GeometryType.js';
import LineString from '../../../../../../src/ol/geom/LineString.js'; import LineString from '../../../../../../src/ol/geom/LineString.js';
import LineStringBatchRenderer from '../../../../../../src/ol/render/webgl/LineStringBatchRenderer.js'; import LineStringBatchRenderer from '../../../../../../src/ol/render/webgl/LineStringBatchRenderer.js';
import MixedGeometryBatch from '../../../../../../src/ol/render/webgl/MixedGeometryBatch.js'; import MixedGeometryBatch from '../../../../../../src/ol/render/webgl/MixedGeometryBatch.js';
@@ -105,7 +104,7 @@ describe('Batch renderers', function () {
batchRenderer.rebuild( batchRenderer.rebuild(
mixedBatch.pointBatch, mixedBatch.pointBatch,
SAMPLE_FRAMESTATE, SAMPLE_FRAMESTATE,
GeometryType.POINT, 'Point',
rebuildCb rebuildCb
); );
// wait for worker response for our specific message // wait for worker response for our specific message
@@ -209,7 +208,7 @@ describe('Batch renderers', function () {
batchRenderer.rebuild( batchRenderer.rebuild(
mixedBatch.lineStringBatch, mixedBatch.lineStringBatch,
SAMPLE_FRAMESTATE, SAMPLE_FRAMESTATE,
GeometryType.LINE_STRING, 'LineString',
rebuildCb rebuildCb
); );
// wait for worker response for our specific message // wait for worker response for our specific message
@@ -272,7 +271,7 @@ describe('Batch renderers', function () {
batchRenderer.rebuild( batchRenderer.rebuild(
mixedBatch.polygonBatch, mixedBatch.polygonBatch,
SAMPLE_FRAMESTATE, SAMPLE_FRAMESTATE,
GeometryType.POLYGON, 'Polygon',
rebuildCb rebuildCb
); );
// wait for worker response for our specific message // wait for worker response for our specific message