ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change ol.Object event name syntax

Browse Source 
'changed' to 'change' and '<attribute>_changed' to 'change:<attribute>'.
This commit is contained in:
Frederic Junod
2013-05-07 16:09:19 +02:00
parent 5e5d8e5b17
commit 984002a7ec
10 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/spec/ol/collection.test.js
View File

@@ -195,30 +195,30 @@ describe('ol.collection', function() {
});
});
describe('length_changed event', function() {
describe('change:length event', function() {
var collection, cb;
beforeEach(function() {
collection = new ol.Collection([0, 1, 2]);
cb = sinon.spy();
goog.events.listen(collection, 'length_changed', cb);
goog.events.listen(collection, 'change:length', cb);
});
describe('insertAt', function() {
it('triggers length_changed event', function() {
it('triggers change:length event', function() {
collection.insertAt(2, 3);
expect(cb).to.be.called();
});
});
describe('removeAt', function() {
it('triggers length_changed event', function() {
it('triggers change:length event', function() {
collection.removeAt(0);
expect(cb).to.be.called();
});
});
describe('setAt', function() {
it('does not trigger length_changed event', function() {
it('does not trigger change:length event', function() {
collection.setAt(1, 1);
expect(cb).to.not.be.called();
});

20
test/spec/ol/object.test.js
View File

@@ -103,15 +103,15 @@ describe('ol.Object', function() {
beforeEach(function() {
listener1 = sinon.spy();
goog.events.listen(o, 'k_changed', listener1);
goog.events.listen(o, 'change:k', listener1);
listener2 = sinon.spy();
goog.events.listen(o, 'changed', listener2);
goog.events.listen(o, 'change', listener2);
var o2 = new ol.Object();
o2.bindTo('k', o);
listener3 = sinon.spy();
goog.events.listen(o2, 'k_changed', listener3);
goog.events.listen(o2, 'change:k', listener3);
});
it('dispatches events', function() {
@@ -136,15 +136,15 @@ describe('ol.Object', function() {
beforeEach(function() {
listener1 = sinon.spy();
goog.events.listen(o, 'k_changed', listener1);
goog.events.listen(o, 'change:k', listener1);
listener2 = sinon.spy();
goog.events.listen(o, 'changed', listener2);
goog.events.listen(o, 'change', listener2);
o2 = new ol.Object();
o2.bindTo('k', o);
listener3 = sinon.spy();
goog.events.listen(o2, 'k_changed', listener3);
goog.events.listen(o2, 'change:k', listener3);
});
it('dispatches events to object', function() {
@@ -288,10 +288,10 @@ describe('ol.Object', function() {
o2.bindTo('k2', o, 'k1');
listener1 = sinon.spy();
goog.events.listen(o, 'k1_changed', listener1);
goog.events.listen(o, 'change:k1', listener1);
listener2 = sinon.spy();
goog.events.listen(o2, 'k2_changed', listener2);
goog.events.listen(o2, 'change:k2', listener2);
});
it('sets the expected properties', function() {
@@ -460,9 +460,9 @@ describe('ol.Object', function() {
beforeEach(function() {
listener1 = sinon.spy();
goog.events.listen(o, 'k_changed', listener1);
goog.events.listen(o, 'change:k', listener1);
listener2 = sinon.spy();
goog.events.listen(o, 'K_changed', listener2);
goog.events.listen(o, 'change:K', listener2);
});
it('dispatches the expected event', function() {