ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not fire modifystart when nothing is being modified

Browse Source
This commit is contained in:
Andreas Hocevar
2021-06-17 10:48:25 +02:00
parent 93b5ec9d43
commit 94a7cdba10
2 changed files with 39 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/browser/spec/ol/interaction/modify.test.js
View File

@@ -20,7 +20,7 @@ import {
clearUserProjection,
setUserProjection,
} from '../../../../../src/ol/proj.js';
import {doubleClick} from '../../../../../src/ol/events/condition.js';
import {doubleClick, never} from '../../../../../src/ol/events/condition.js';
import {getValues} from '../../../../../src/ol/obj.js';
describe('ol.interaction.Modify', function () {
@@ -853,6 +853,33 @@ describe('ol.interaction.Modify', function () {
expect(listenerSpy.callCount).to.be(1);
expect(feature.getGeometry().getCoordinates()[0]).to.have.length(5);
});
it('does not fire `modifystart` when nothing is modified', function (done) {
const modify = new Modify({
features: new Collection(features),
insertVertexCondition: never,
});
map.addInteraction(modify);
let modifystart = false;
modify.on('modifystart', function () {
modifystart = true;
});
// try to add vertex
simulateEvent('pointermove', 40, -20, null, 0);
simulateEvent('pointerdown', 40, -20, null, 0);
simulateEvent('pointermove', 42, -30, null, 0);
simulateEvent('pointerdrag', 42, -30, null, 0);
simulateEvent('pointerup', 42, -30, null, 0);
simulateEvent('click', 42, -30, null, 0);
simulateEvent('singleclick', 42, -30, null, 0);
setTimeout(function () {
expect(modifystart).to.be(false);
done();
}, 0);
});
});
describe('handle feature change', function () {