ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not rely on old value for target

Browse Source
This commit is contained in:
Andreas Hocevar
2020-07-27 17:23:42 +02:00
parent cad5057a96
commit 93d3528047
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ol/PluggableMap.js
View File

@@ -1103,10 +1103,9 @@ class PluggableMap extends BaseObject {
} }
/** /**
* @param {import("./Object").ObjectEvent} event Event.
* @private * @private
*/ */
handleTargetChanged_(event) { handleTargetChanged_() {
// target may be undefined, null, a string or an Element. // target may be undefined, null, a string or an Element.
// If it's a string we convert it to an Element before proceeding. // If it's a string we convert it to an Element before proceeding.
// If it's not now an Element we remove the viewport from the DOM. // If it's not now an Element we remove the viewport from the DOM.
@@ -1117,7 +1116,7 @@ class PluggableMap extends BaseObject {
targetElement = this.getTargetElement(); targetElement = this.getTargetElement();
} }
if (event.oldValue) { if (this.mapBrowserEventHandler_) {
for (let i = 0, ii = this.keyHandlerKeys_.length; i < ii; ++i) { for (let i = 0, ii = this.keyHandlerKeys_.length; i < ii; ++i) {
unlistenByKey(this.keyHandlerKeys_[i]); unlistenByKey(this.keyHandlerKeys_[i]);
} }
@@ -1135,6 +1134,7 @@ class PluggableMap extends BaseObject {
this.handleResize_ = undefined; this.handleResize_ = undefined;
} }
this.mapBrowserEventHandler_.dispose(); this.mapBrowserEventHandler_.dispose();
this.mapBrowserEventHandler_ = null;
removeNode(this.viewport_); removeNode(this.viewport_);
} }