ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unused insert_at, set_at, and remove_at events

Browse Source
This commit is contained in:
Tom Payne
2013-03-06 15:28:36 +01:00
parent 3a7c4bd3bc
commit 905a0059db
2 changed files with 33 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
test/spec/ol/collection.test.js
View File

@@ -107,64 +107,62 @@ describe('ol.collection', function() {
describe('setAt and event', function() {
it('does dispatch events', function() {
var collection = new ol.Collection(['a', 'b']);
var index, prev;
var added, removed;
goog.events.listen(collection, ol.CollectionEventType.ADD, function(e) {
added = e.elem;
});
goog.events.listen(
collection,
ol.CollectionEventType.SET_AT,
function(e) {
index = e.index;
prev = e.prev;
collection, ol.CollectionEventType.REMOVE, function(e) {
removed = e.elem;
});
collection.setAt(1, 1);
expect(index).toEqual(1);
expect(prev).toEqual('b');
expect(added).toEqual(1);
expect(removed).toEqual('b');
});
});
describe('removeAt and event', function() {
it('does dispatch events', function() {
var collection = new ol.Collection(['a']);
var index, prev;
var removed;
goog.events.listen(
collection, ol.CollectionEventType.REMOVE_AT, function(e) {
index = e.index;
prev = e.prev;
collection, ol.CollectionEventType.REMOVE, function(e) {
removed = e.elem;
});
collection.pop();
expect(index).toEqual(0);
expect(prev).toEqual('a');
expect(removed).toEqual('a');
});
});
describe('insertAt and event', function() {
it('does dispatch events', function() {
var collection = new ol.Collection([0, 2]);
var index;
var added;
goog.events.listen(
collection, ol.CollectionEventType.INSERT_AT, function(e) {
index = e.index;
collection, ol.CollectionEventType.ADD, function(e) {
added = e.elem;
});
collection.insertAt(1, 1);
expect(index).toEqual(1);
expect(added).toEqual(1);
});
});
describe('setAt beyond end', function() {
it('triggers events properly', function() {
var inserts = [];
var added = [];
goog.events.listen(
collection, ol.CollectionEventType.INSERT_AT, function(e) {
inserts.push(e.index);
collection, ol.CollectionEventType.ADD, function(e) {
added.push(e.elem);
});
collection.setAt(2, 0);
expect(collection.getLength()).toEqual(3);
expect(collection.getAt(0)).toBeUndefined();
expect(collection.getAt(1)).toBeUndefined();
expect(collection.getAt(2)).toEqual(0);
expect(inserts.length).toEqual(3);
expect(inserts[0]).toEqual(0);
expect(inserts[1]).toEqual(1);
expect(inserts[2]).toEqual(2);
expect(added.length).toEqual(3);
expect(added[0]).toEqual(undefined);
expect(added[1]).toEqual(undefined);
expect(added[2]).toEqual(0);
});
});