ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

deprecate OpenLayers.Element hide() / show(). r=crschmidt (closes #1099)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11573 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Frédéric Junod
2011-02-28 08:05:56 +00:00
parent 31f1dd2610
commit 8beb04d2ca
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/BaseTypes/Element.js
+10 -2
View File
@@ -45,12 +45,16 @@ OpenLayers.Element = {
/** /**
* APIFunction: hide * APIFunction: hide
* Hide element(s) passed in * *Deprecated*. Hide element(s) passed in
* *
* Parameters: * Parameters:
* element - {DOMElement} Actually user can pass any number of elements * element - {DOMElement} Actually user can pass any number of elements
*/ */
hide: function() { hide: function() {
OpenLayers.Console.warn(OpenLayers.i18n("methodDeprecated", {
newMethod: "element.style.display = 'none';"
}));
for (var i=0, len=arguments.length; i<len; i++) { for (var i=0, len=arguments.length; i<len; i++) {
var element = OpenLayers.Util.getElement(arguments[i]); var element = OpenLayers.Util.getElement(arguments[i]);
if (element) { if (element) {
@@ -61,12 +65,16 @@ OpenLayers.Element = {
/** /**
* APIFunction: show * APIFunction: show
* Show element(s) passed in * *Deprecated*. Show element(s) passed in
* *
* Parameters: * Parameters:
* element - {DOMElement} Actually user can pass any number of elements * element - {DOMElement} Actually user can pass any number of elements
*/ */
show: function() { show: function() {
OpenLayers.Console.warn(OpenLayers.i18n("methodDeprecated", {
newMethod: "element.style.display = '';"
}));
for (var i=0, len=arguments.length; i<len; i++) { for (var i=0, len=arguments.length; i<len; i++) {
var element = OpenLayers.Util.getElement(arguments[i]); var element = OpenLayers.Util.getElement(arguments[i]);
if (element) { if (element) {
lib/OpenLayers/Popup.js
+2 -2
View File
@@ -431,7 +431,7 @@ OpenLayers.Popup = OpenLayers.Class({
* Makes the popup visible. * Makes the popup visible.
*/ */
show: function() { show: function() {
OpenLayers.Element.show(this.div); this.div.style.display = '';
if (this.panMapIfOutOfView) { if (this.panMapIfOutOfView) {
this.panIntoView(); this.panIntoView();
@@ -443,7 +443,7 @@ OpenLayers.Popup = OpenLayers.Class({
* Makes the popup invisible. * Makes the popup invisible.
*/ */
hide: function() { hide: function() {
OpenLayers.Element.hide(this.div); this.div.style.display = 'none';
}, },
/** /**