From 807b0eabaa825af2c6627fdcf422ff2da2e61ea0 Mon Sep 17 00:00:00 2001 From: Bart van den Eijnden Date: Fri, 23 Sep 2011 14:44:23 +0200 Subject: [PATCH] cannot draw a label with value 0, r=fredj (closes #3258) --- lib/OpenLayers/Style.js | 2 +- tests/Style.html | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/OpenLayers/Style.js b/lib/OpenLayers/Style.js index 302a9f2e15..55ed81e0c9 100644 --- a/lib/OpenLayers/Style.js +++ b/lib/OpenLayers/Style.js @@ -191,7 +191,7 @@ OpenLayers.Style = OpenLayers.Class({ style.display = "none"; } - if (style.label && typeof style.label !== "string") { + if (style.label != null && typeof style.label !== "string") { style.label = String(style.label); } diff --git a/tests/Style.html b/tests/Style.html index 2c3a18b176..0b8b33b467 100644 --- a/tests/Style.html +++ b/tests/Style.html @@ -176,9 +176,9 @@ // c) test that label in returned symbolizer is a string even if property value is a number var symbolizer = style.createSymbolizer( - new OpenLayers.Feature.Vector(null, {foo: "bar", labelValue: 10}) + new OpenLayers.Feature.Vector(null, {foo: "bar", labelValue: 0}) ); - t.eq(symbolizer.label, "10", "c) feature property cast to string when used as symbolizer label"); + t.eq(symbolizer.label, "0", "c) feature property cast to string when used as symbolizer label"); }