From 7fbc4e3bff748e80937be23bf6c207f87b15cb93 Mon Sep 17 00:00:00 2001 From: Antoine Abt Date: Mon, 21 Jul 2014 12:27:59 +0200 Subject: [PATCH] Rename ol3Logo to logo in map options --- externs/olx.js | 4 ++-- src/ol/map.js | 19 ++++++++++--------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/externs/olx.js b/externs/olx.js index f00d92a889..e20d456049 100644 --- a/externs/olx.js +++ b/externs/olx.js @@ -106,7 +106,7 @@ olx.GeolocationOptions.prototype.projection; * interactions: (ol.Collection|Array.|undefined), * keyboardEventTarget: (Element|Document|string|undefined), * layers: (Array.|ol.Collection|undefined), - * ol3Logo: (boolean|undefined), + * logo: (boolean|string|Object|undefined), * overlays: (ol.Collection|Array.|undefined), * renderer: (ol.RendererType|Array.|string|undefined), * target: (Element|string|undefined), @@ -171,7 +171,7 @@ olx.MapOptions.prototype.layers; * Show ol3 logo. Default is `true`. * @type {boolean|undefined} */ -olx.MapOptions.prototype.ol3Logo; +olx.MapOptions.prototype.logo; /** diff --git a/src/ol/map.js b/src/ol/map.js index 5b52b621ce..0bdf3f0f5d 100644 --- a/src/ol/map.js +++ b/src/ol/map.js @@ -172,9 +172,9 @@ ol.Map = function(options) { /** * @private - * @type {boolean} + * @type {Object} */ - this.ol3Logo_ = optionsInternal.ol3Logo; + this.logos_ = optionsInternal.logos; /** * @private @@ -1209,7 +1209,7 @@ ol.Map.prototype.renderFrame_ = function(time) { index: this.frameIndex_++, layerStates: layerStates, layerStatesArray: layerStatesArray, - logos: {}, + logos: this.logos_, pixelRatio: this.pixelRatio_, pixelToCoordinateMatrix: this.pixelToCoordinateMatrix_, postRenderFunctions: [], @@ -1222,9 +1222,6 @@ ol.Map.prototype.renderFrame_ = function(time) { viewHints: viewHints, wantedTiles: {} }); - if (this.ol3Logo_) { - frameState.logos[ol.OL3_LOGO_URL] = ol.OL3_URL; - } } var preRenderFunctions = this.preRenderFunctions_; @@ -1382,7 +1379,7 @@ ol.Map.prototype.unskipFeature = function(feature) { * deviceOptions: olx.DeviceOptions, * interactions: ol.Collection, * keyboardEventTarget: (Element|Document), - * ol3Logo: boolean, + * logos: Object, * overlays: ol.Collection, * rendererConstructor: * function(new: ol.renderer.Map, Element, ol.Map), @@ -1414,7 +1411,11 @@ ol.Map.createOptionsInternal = function(options) { */ var values = {}; - var ol3Logo = goog.isDef(options.ol3Logo) ? options.ol3Logo : true; + var logos = {}; + if (!goog.isDef(options.logo) || + (goog.isBoolean(options.logo) && options.logo)) { + logos[ol.OL3_LOGO_URL] = ol.OL3_URL; + } var layerGroup = (options.layers instanceof ol.layer.Group) ? options.layers : new ol.layer.Group({layers: options.layers}); @@ -1512,7 +1513,7 @@ ol.Map.createOptionsInternal = function(options) { deviceOptions: deviceOptions, interactions: interactions, keyboardEventTarget: keyboardEventTarget, - ol3Logo: ol3Logo, + logos: logos, overlays: overlays, rendererConstructor: rendererConstructor, values: values