Merge pull request #1017 from tschaub/provide-objects-only

Never use goog.provide with primitives (especially with falsely values).
This commit is contained in:
Tim Schaub
2013-09-16 06:46:26 -07:00
17 changed files with 22 additions and 21 deletions
+1 -1
View File
@@ -4,7 +4,7 @@ goog.require('ol.View2D');
goog.require('ol.dom.Input'); goog.require('ol.dom.Input');
goog.require('ol.layer.Tile'); goog.require('ol.layer.Tile');
goog.require('ol.source.OSM'); goog.require('ol.source.OSM');
goog.require('ol.webgl.SUPPORTED'); goog.require('ol.webgl');
if (!ol.webgl.SUPPORTED) { if (!ol.webgl.SUPPORTED) {
+1 -1
View File
@@ -3,7 +3,7 @@ goog.require('ol.RendererHint');
goog.require('ol.View2D'); goog.require('ol.View2D');
goog.require('ol.layer.Tile'); goog.require('ol.layer.Tile');
goog.require('ol.source.MapQuestOpenAerial'); goog.require('ol.source.MapQuestOpenAerial');
goog.require('ol.webgl.SUPPORTED'); goog.require('ol.webgl');
function setResetBrightnessButtonHTML() { function setResetBrightnessButtonHTML() {
+1 -1
View File
@@ -4,7 +4,7 @@ goog.require('ol.View2D');
goog.require('ol.layer.Tile'); goog.require('ol.layer.Tile');
goog.require('ol.proj'); goog.require('ol.proj');
goog.require('ol.source.BingMaps'); goog.require('ol.source.BingMaps');
goog.require('ol.webgl.SUPPORTED'); goog.require('ol.webgl');
function setResetHueButtonHTML() { function setResetHueButtonHTML() {
+1 -1
View File
@@ -3,7 +3,7 @@ goog.require('ol.RendererHint');
goog.require('ol.View2D'); goog.require('ol.View2D');
goog.require('ol.layer.Tile'); goog.require('ol.layer.Tile');
goog.require('ol.source.MapQuestOpenAerial'); goog.require('ol.source.MapQuestOpenAerial');
goog.require('ol.webgl.SUPPORTED'); goog.require('ol.webgl');
var domMap = new ol.Map({ var domMap = new ol.Map({
+1 -1
View File
@@ -9,7 +9,7 @@ goog.require('ol.layer.Tile');
goog.require('ol.layer.Vector2'); goog.require('ol.layer.Vector2');
goog.require('ol.source.OSM'); goog.require('ol.source.OSM');
goog.require('ol.source.Vector2'); goog.require('ol.source.Vector2');
goog.require('ol.webgl.SUPPORTED'); goog.require('ol.webgl');
// WARNING // WARNING
-1
View File
@@ -1 +0,0 @@
@exportSymbol ol.canvas.SUPPORTED
-1
View File
@@ -1,5 +1,4 @@
goog.provide('ol.canvas'); goog.provide('ol.canvas');
goog.provide('ol.canvas.SUPPORTED');
goog.require('goog.dom'); goog.require('goog.dom');
goog.require('goog.dom.TagName'); goog.require('goog.dom.TagName');
-1
View File
@@ -1,2 +1 @@
@exportClass ol.DeviceOrientation ol.DeviceOrientationOptions @exportClass ol.DeviceOrientation ol.DeviceOrientationOptions
@exportSymbol ol.DeviceOrientation.SUPPORTED
+4 -1
View File
@@ -1,5 +1,4 @@
goog.provide('ol.DeviceOrientation'); goog.provide('ol.DeviceOrientation');
goog.provide('ol.DeviceOrientation.SUPPORTED');
goog.provide('ol.DeviceOrientationProperty'); goog.provide('ol.DeviceOrientationProperty');
goog.require('goog.events'); goog.require('goog.events');
@@ -107,6 +106,10 @@ ol.DeviceOrientation.prototype.disposeInternal = function() {
* @type {boolean} * @type {boolean}
*/ */
ol.DeviceOrientation.SUPPORTED = 'DeviceOrientationEvent' in window; ol.DeviceOrientation.SUPPORTED = 'DeviceOrientationEvent' in window;
goog.exportProperty(
ol.DeviceOrientation,
'SUPPORTED',
ol.DeviceOrientation.SUPPORTED);
/** /**
-1
View File
@@ -1,2 +1 @@
@exportClass ol.Geolocation ol.GeolocationOptions @exportClass ol.Geolocation ol.GeolocationOptions
@exportSymbol ol.Geolocation.SUPPORTED
+4 -1
View File
@@ -1,7 +1,6 @@
// FIXME handle geolocation not supported // FIXME handle geolocation not supported
goog.provide('ol.Geolocation'); goog.provide('ol.Geolocation');
goog.provide('ol.Geolocation.SUPPORTED');
goog.provide('ol.GeolocationProperty'); goog.provide('ol.GeolocationProperty');
goog.require('goog.events'); goog.require('goog.events');
@@ -143,6 +142,10 @@ ol.Geolocation.prototype.handleTrackingChanged_ = function() {
* @type {boolean} * @type {boolean}
*/ */
ol.Geolocation.SUPPORTED = 'geolocation' in goog.global.navigator; ol.Geolocation.SUPPORTED = 'geolocation' in goog.global.navigator;
goog.exportProperty(
ol.Geolocation,
'SUPPORTED',
ol.Geolocation.SUPPORTED);
/** /**
+3 -3
View File
@@ -58,12 +58,12 @@ goog.require('ol.layer.Group');
goog.require('ol.proj'); goog.require('ol.proj');
goog.require('ol.proj.common'); goog.require('ol.proj.common');
goog.require('ol.renderer.Map'); goog.require('ol.renderer.Map');
goog.require('ol.renderer.canvas');
goog.require('ol.renderer.canvas.Map'); goog.require('ol.renderer.canvas.Map');
goog.require('ol.renderer.canvas.SUPPORTED'); goog.require('ol.renderer.dom');
goog.require('ol.renderer.dom.Map'); goog.require('ol.renderer.dom.Map');
goog.require('ol.renderer.dom.SUPPORTED'); goog.require('ol.renderer.webgl');
goog.require('ol.renderer.webgl.Map'); goog.require('ol.renderer.webgl.Map');
goog.require('ol.renderer.webgl.SUPPORTED');
goog.require('ol.structs.PriorityQueue'); goog.require('ol.structs.PriorityQueue');
goog.require('ol.vec.Mat4'); goog.require('ol.vec.Mat4');
+2 -2
View File
@@ -1,6 +1,6 @@
goog.provide('ol.renderer.canvas.SUPPORTED'); goog.provide('ol.renderer.canvas');
goog.require('ol.canvas.SUPPORTED'); goog.require('ol.canvas');
/** /**
+1 -1
View File
@@ -1,4 +1,4 @@
goog.provide('ol.renderer.dom.SUPPORTED'); goog.provide('ol.renderer.dom');
/** /**
+2 -2
View File
@@ -1,6 +1,6 @@
goog.provide('ol.renderer.webgl.SUPPORTED'); goog.provide('ol.renderer.webgl');
goog.require('ol.webgl.SUPPORTED'); goog.require('ol.webgl');
/** /**
-1
View File
@@ -1 +0,0 @@
@exportSymbol ol.webgl.SUPPORTED
+1 -1
View File
@@ -1,5 +1,4 @@
goog.provide('ol.webgl'); goog.provide('ol.webgl');
goog.provide('ol.webgl.SUPPORTED');
goog.provide('ol.webgl.WebGLContextEventType'); goog.provide('ol.webgl.WebGLContextEventType');
goog.require('goog.dom'); goog.require('goog.dom');
@@ -64,3 +63,4 @@ ol.webgl.SUPPORTED = (function() {
return false; return false;
} }
})(); })();
goog.exportSymbol('ol.webgl.SUPPORTED', ol.webgl.SUPPORTED);