ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3420 from elemoine/leaks

Browse Source 
Unregister viewport size listener on setTarget(null)
This commit is contained in:
Éric Lemoine
2015-04-03 20:07:20 +02:00
parent da9de6ef1b f1d7e2ec85
commit 7c0977de45
3 changed files with 52 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test/spec/ol/map.test.js
View File

@@ -187,6 +187,39 @@ describe('ol.Map', function() {
});
});
describe('#setTarget', function() {
var map;
beforeEach(function() {
map = new ol.Map({
target: document.createElement('div')
});
var viewportResizeListeners = map.viewportSizeMonitor_.getListeners(
goog.events.EventType.RESIZE, false);
expect(viewportResizeListeners).to.have.length(1);
});
describe('call setTarget with null', function() {
it('unregisters the viewport resize listener', function() {
map.setTarget(null);
var viewportResizeListeners = map.viewportSizeMonitor_.getListeners(
goog.events.EventType.RESIZE, false);
expect(viewportResizeListeners).to.have.length(0);
});
});
describe('call setTarget with an element', function() {
it('registers a viewport resize listener', function() {
map.setTarget(null);
map.setTarget(document.createElement('div'));
var viewportResizeListeners = map.viewportSizeMonitor_.getListeners(
goog.events.EventType.RESIZE, false);
expect(viewportResizeListeners).to.have.length(1);
});
});
});
describe('create interactions', function() {
var options;
@@ -244,6 +277,7 @@ describe('ol.Map', function() {
goog.require('goog.dispose');
goog.require('goog.dom');
goog.require('goog.events.EventType');
goog.require('ol.Map');
goog.require('ol.MapEvent');
goog.require('ol.View');