Merge pull request #12408 from ahocevar/modify-no-insert

Do not fire modifystart when nothing is being modified
2021-06-21 08:05:53 +02:00
parent 4dd75d75e3 94a7cdba10
commit 7777821df5
2 changed files with 39 additions and 9 deletions
--- a/src/ol/interaction/Modify.js
+++ b/src/ol/interaction/Modify.js
@@ -435,14 +435,17 @@ class Modify extends PointerInteraction {
          }
        }
      }
-
-      this.dispatchEvent(
-        new ModifyEvent(
-          ModifyEventType.MODIFYSTART,
-          this.featuresBeingModified_,
-          evt
-        )
-      );
+      if (this.featuresBeingModified_.getLength() === 0) {
+        this.featuresBeingModified_ = null;
+      } else {
+        this.dispatchEvent(
+          new ModifyEvent(
+            ModifyEventType.MODIFYSTART,
+            this.featuresBeingModified_,
+            evt
+          )
+        );
+      }
    }
  }