From 6e4aa39e9d9d77d6fbb86bc7a6f4586ca07faaf1 Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Tue, 10 Jan 2017 08:49:11 +0100 Subject: [PATCH 1/4] Add curly braces in type annotation --- src/ol/view.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ol/view.js b/src/ol/view.js index 32fb696f90..15cdd7e907 100644 --- a/src/ol/view.js +++ b/src/ol/view.js @@ -217,7 +217,7 @@ ol.View.prototype.animate = function(var_args) { } var series = []; for (var i = 0; i < animationCount; ++i) { - var options = /** @type olx.AnimationOptions */ (arguments[i]); + var options = /** @type {olx.AnimationOptions} */ (arguments[i]); var animation = /** @type {ol.ViewAnimation} */ ({ start: start, From 01e161e19f544ac3539ae05cbd39e902676c1d8b Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Tue, 10 Jan 2017 08:50:39 +0100 Subject: [PATCH 2/4] Remove unused private variable --- src/ol/renderer/canvas/tilelayer.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/ol/renderer/canvas/tilelayer.js b/src/ol/renderer/canvas/tilelayer.js index bb5828bbba..603f3edab4 100644 --- a/src/ol/renderer/canvas/tilelayer.js +++ b/src/ol/renderer/canvas/tilelayer.js @@ -52,12 +52,6 @@ ol.renderer.canvas.TileLayer = function(tileLayer) { */ this.tmpExtent = ol.extent.createEmpty(); - /** - * @private - * @type {ol.TileCoord} - */ - this.tmpTileCoord_ = [0, 0, 0]; - /** * @private * @type {ol.TileRange} From 22498991ababfe2be0d61cafa9aa83e10ec9d5af Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Tue, 10 Jan 2017 08:51:41 +0100 Subject: [PATCH 3/4] Remove unused private function --- src/ol/kinetic.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/ol/kinetic.js b/src/ol/kinetic.js index 65adb7a583..3932c2dd12 100644 --- a/src/ol/kinetic.js +++ b/src/ol/kinetic.js @@ -103,15 +103,6 @@ ol.Kinetic.prototype.end = function() { }; -/** - * @private - * @return {number} Duration of animation (milliseconds). - */ -ol.Kinetic.prototype.getDuration_ = function() { - return Math.log(this.minVelocity_ / this.initialVelocity_) / this.decay_; -}; - - /** * @return {number} Total distance travelled (pixels). */ From 56320844419899dccbf5f538b5c9112b08d7ce0d Mon Sep 17 00:00:00 2001 From: Frederic Junod Date: Tue, 10 Jan 2017 08:58:15 +0100 Subject: [PATCH 4/4] Remove 'analyzerChecks' from jscomp_off compiler option --- config/example.json | 1 - config/examples-all.json | 3 +-- config/ol.json | 3 +-- doc/tutorials/closure.md | 3 +-- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/config/example.json b/config/example.json index d034d67b76..dff7c67e16 100644 --- a/config/example.json +++ b/config/example.json @@ -28,7 +28,6 @@ ], "jscomp_off": [ "lintChecks", - "analyzerChecks", "missingProvide", "unknownDefines" ], diff --git a/config/examples-all.json b/config/examples-all.json index 3544621ee9..3c66049069 100644 --- a/config/examples-all.json +++ b/config/examples-all.json @@ -27,8 +27,7 @@ "*" ], "jscomp_off": [ - "lintChecks", - "analyzerChecks" + "lintChecks" ], "extra_annotation_name": [ "api", "observable" diff --git a/config/ol.json b/config/ol.json index 25a3ec4290..aa2e47040b 100644 --- a/config/ol.json +++ b/config/ol.json @@ -18,8 +18,7 @@ "*" ], "jscomp_off": [ - "lintChecks", - "analyzerChecks" + "lintChecks" ], "extra_annotation_name": [ "api", "observable" diff --git a/doc/tutorials/closure.md b/doc/tutorials/closure.md index 7221445bef..723b915003 100644 --- a/doc/tutorials/closure.md +++ b/doc/tutorials/closure.md @@ -230,8 +230,7 @@ Here is a version of `config.json` with more compilation checks enabled: ], "jscomp_off": [ "unknownDefines", - "lintChecks", - "analyzerChecks" + "lintChecks" ], "extra_annotation_name": [ "api", "observable"