ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use opt_this instead of opt_obj in ol.xml

Browse Source
This commit is contained in:
Tom Payne
2014-01-15 15:09:42 +01:00
parent af8e92c0bf
commit 71a6897223
1 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ol/xml.js
+19 -18
View File
@@ -51,18 +51,18 @@ ol.xml.getAllTextContent_ = function(node, normalizeWhitespace, accumulator) {
/** /**
* @param {function(this: T, Node, Array.<*>): (Array.<*>|undefined)} * @param {function(this: T, Node, Array.<*>): (Array.<*>|undefined)}
* valueReader Value reader. * valueReader Value reader.
* @param {T=} opt_obj Scope. * @param {T=} opt_this The object to use as `this` in `valueReader`.
* @return {ol.xml.Parser} Parser. * @return {ol.xml.Parser} Parser.
* @template T * @template T
*/ */
ol.xml.makeArrayExtender = function(valueReader, opt_obj) { ol.xml.makeArrayExtender = function(valueReader, opt_this) {
return ( return (
/** /**
* @param {Node} node Node. * @param {Node} node Node.
* @param {Array.<*>} objectStack Object stack. * @param {Array.<*>} objectStack Object stack.
*/ */
function(node, objectStack) { function(node, objectStack) {
var value = valueReader.call(opt_obj, node, objectStack); var value = valueReader.call(opt_this, node, objectStack);
if (goog.isDef(value)) { if (goog.isDef(value)) {
goog.asserts.assert(goog.isArray(value)); goog.asserts.assert(goog.isArray(value));
var array = /** @type {Array.<*>} */ var array = /** @type {Array.<*>} */
@@ -76,18 +76,18 @@ ol.xml.makeArrayExtender = function(valueReader, opt_obj) {
/** /**
* @param {function(this: T, Node, Array.<*>): *} valueReader Value reader. * @param {function(this: T, Node, Array.<*>): *} valueReader Value reader.
* @param {T=} opt_obj Scope. * @param {T=} opt_this The object to use as `this` in `valueReader`.
* @return {ol.xml.Parser} Parser. * @return {ol.xml.Parser} Parser.
* @template T * @template T
*/ */
ol.xml.makeArrayPusher = function(valueReader, opt_obj) { ol.xml.makeArrayPusher = function(valueReader, opt_this) {
return ( return (
/** /**
* @param {Node} node Node. * @param {Node} node Node.
* @param {Array.<*>} objectStack Object stack. * @param {Array.<*>} objectStack Object stack.
*/ */
function(node, objectStack) { function(node, objectStack) {
var value = valueReader.call(opt_obj, node, objectStack); var value = valueReader.call(opt_this, node, objectStack);
if (goog.isDef(value)) { if (goog.isDef(value)) {
var array = objectStack[objectStack.length - 1]; var array = objectStack[objectStack.length - 1];
goog.asserts.assert(goog.isArray(array)); goog.asserts.assert(goog.isArray(array));
@@ -99,18 +99,18 @@ ol.xml.makeArrayPusher = function(valueReader, opt_obj) {
/** /**
* @param {function(this: T, Node, Array.<*>): *} valueReader Value reader. * @param {function(this: T, Node, Array.<*>): *} valueReader Value reader.
* @param {T=} opt_obj Scope. * @param {T=} opt_this The object to use as `this` in `valueReader`.
* @return {ol.xml.Parser} Parser. * @return {ol.xml.Parser} Parser.
* @template T * @template T
*/ */
ol.xml.makeReplacer = function(valueReader, opt_obj) { ol.xml.makeReplacer = function(valueReader, opt_this) {
return ( return (
/** /**
* @param {Node} node Node. * @param {Node} node Node.
* @param {Array.<*>} objectStack Object stack. * @param {Array.<*>} objectStack Object stack.
*/ */
function(node, objectStack) { function(node, objectStack) {
var value = valueReader.call(opt_obj, node, objectStack); var value = valueReader.call(opt_this, node, objectStack);
if (goog.isDef(value)) { if (goog.isDef(value)) {
objectStack[objectStack.length - 1] = value; objectStack[objectStack.length - 1] = value;
} }
@@ -121,11 +121,12 @@ ol.xml.makeReplacer = function(valueReader, opt_obj) {
/** /**
* @param {function(this: T, Node, Array.<*>): *} valueReader Value reader. * @param {function(this: T, Node, Array.<*>): *} valueReader Value reader.
* @param {string=} opt_property Property. * @param {string=} opt_property Property.
* @param {T=} opt_obj Scope. * @param {T=} opt_this The object to use as `this` in `valueReader`.
* @return {ol.xml.Parser} Parser. * @return {ol.xml.Parser} Parser.
* @template T * @template T
*/ */
ol.xml.makeObjectPropertySetter = function(valueReader, opt_property, opt_obj) { ol.xml.makeObjectPropertySetter =
function(valueReader, opt_property, opt_this) {
goog.asserts.assert(goog.isDef(valueReader)); goog.asserts.assert(goog.isDef(valueReader));
return ( return (
/** /**
@@ -133,7 +134,7 @@ ol.xml.makeObjectPropertySetter = function(valueReader, opt_property, opt_obj) {
* @param {Array.<*>} objectStack Object stack. * @param {Array.<*>} objectStack Object stack.
*/ */
function(node, objectStack) { function(node, objectStack) {
var value = valueReader.call(opt_obj, node, objectStack); var value = valueReader.call(opt_this, node, objectStack);
if (goog.isDef(value)) { if (goog.isDef(value)) {
var object = /** @type {Object} */ var object = /** @type {Object} */
(objectStack[objectStack.length - 1]); (objectStack[objectStack.length - 1]);
@@ -169,16 +170,16 @@ ol.xml.makeParsersNS = function(namespaceURIs, parsers, opt_parsersNS) {
* Parsers by namespace. * Parsers by namespace.
* @param {Node} node Node. * @param {Node} node Node.
* @param {Array.<*>} objectStack Object stack. * @param {Array.<*>} objectStack Object stack.
* @param {*=} opt_obj Scope. * @param {*=} opt_this The object to use as `this`.
*/ */
ol.xml.parse = function(parsersNS, node, objectStack, opt_obj) { ol.xml.parse = function(parsersNS, node, objectStack, opt_this) {
var n; var n;
for (n = node.firstElementChild; !goog.isNull(n); n = n.nextElementSibling) { for (n = node.firstElementChild; !goog.isNull(n); n = n.nextElementSibling) {
var parsers = parsersNS[n.namespaceURI]; var parsers = parsersNS[n.namespaceURI];
if (goog.isDef(parsers)) { if (goog.isDef(parsers)) {
var parser = parsers[n.localName]; var parser = parsers[n.localName];
if (goog.isDef(parser)) { if (goog.isDef(parser)) {
parser.call(opt_obj, n, objectStack); parser.call(opt_this, n, objectStack);
} }
} }
} }
@@ -191,12 +192,12 @@ ol.xml.parse = function(parsersNS, node, objectStack, opt_obj) {
* Parsers by namespace. * Parsers by namespace.
* @param {Node} node Node. * @param {Node} node Node.
* @param {Array.<*>} objectStack Object stack. * @param {Array.<*>} objectStack Object stack.
* @param {*=} opt_obj Scope. * @param {*=} opt_this The object to use as `this`.
* @return {T|undefined} Object. * @return {T|undefined} Object.
* @template T * @template T
*/ */
ol.xml.pushAndParse = function(object, parsersNS, node, objectStack, opt_obj) { ol.xml.pushAndParse = function(object, parsersNS, node, objectStack, opt_this) {
objectStack.push(object); objectStack.push(object);
ol.xml.parse(parsersNS, node, objectStack, opt_obj); ol.xml.parse(parsersNS, node, objectStack, opt_this);
return objectStack.pop(); return objectStack.pop();
}; };