ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prevent inserting undefined into Collection

Browse Source
This commit is contained in:
Maximilian Krög
2022-07-30 03:18:18 +02:00
parent 806843f449
commit 6e4e49644d
3 changed files with 58 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
test/node/ol/Collection.test.js
View File

@@ -73,10 +73,15 @@ describe('ol/Collection.js', function () {
describe('setAt', function () {
it('sets at the correct location', function () {
collection.setAt(1, 1);
expect(collection.getLength()).to.eql(2);
expect(collection.item(0)).to.be(undefined);
expect(collection.item(1)).to.eql(1);
collection.setAt(0, 1);
collection.setAt(1, 2);
expect(collection.getLength()).to.be(2);
expect(collection.item(0)).to.be(1);
expect(collection.item(1)).to.be(2);
collection.setAt(0, 3);
expect(collection.getLength()).to.be(2);
expect(collection.item(0)).to.be(3);
});
});
@@ -195,23 +200,32 @@ describe('ol/Collection.js', function () {
});
describe('setAt beyond end', function () {
it('does not allow setting invalid index', function () {
try {
collection.setAt(1, 1);
} catch (e) {
return;
}
throw new Error('Collection should throw');
});
it('triggers events properly', function () {
const added = [],
addedIndexes = [];
const added = [];
const addedIndexes = [];
listen(collection, CollectionEventType.ADD, function (e) {
added.push(e.element);
addedIndexes.push(e.index);
});
collection.setAt(2, 0);
expect(collection.getLength()).to.eql(3);
expect(collection.item(0)).to.be(undefined);
expect(collection.item(1)).to.be(undefined);
expect(collection.item(2)).to.eql(0);
expect(added.length).to.eql(3);
expect(added[0]).to.eql(undefined);
expect(added[1]).to.eql(undefined);
expect(added[2]).to.eql(0);
expect(addedIndexes).to.eql([0, 1, 2]);
collection.setAt(0, 0);
collection.setAt(1, 1);
collection.setAt(0, 2);
expect(collection.getLength()).to.be(2);
expect(collection.item(0)).to.be(2);
expect(collection.item(1)).to.be(1);
expect(added.length).to.be(3);
expect(added[0]).to.be(0);
expect(added[1]).to.be(1);
expect(added[2]).to.be(2);
expect(addedIndexes).to.eql([0, 1, 0]);
});
});