From 4fec8d4615ef5b76efb7d9c29164156e3e8d2094 Mon Sep 17 00:00:00 2001
From: Andreas Hocevar <andreas.hocevar@gmail.com>
Date: Sat, 16 Jul 2022 13:18:14 +0200
Subject: [PATCH] Recover from incorrect rebase after removal of string enums

---
 src/ol/renderer/Layer.js                    |  2 +-
 test/browser/spec/ol/renderer/layer.test.js | 23 ++++++++++++++++++---
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/src/ol/renderer/Layer.js b/src/ol/renderer/Layer.js
index 97358ff622..a1b73dea0e 100644
--- a/src/ol/renderer/Layer.js
+++ b/src/ol/renderer/Layer.js
@@ -195,7 +195,7 @@ class LayerRenderer extends Observable {
    */
   renderIfReadyAndVisible() {
     const layer = this.getLayer();
-    if (layer && layer.getVisible() && 'ready') {
+    if (layer && layer.getVisible() && layer.getSourceState() === 'ready') {
       layer.changed();
     }
   }
diff --git a/test/browser/spec/ol/renderer/layer.test.js b/test/browser/spec/ol/renderer/layer.test.js
index 44ed7d2950..ddaaa0f767 100644
--- a/test/browser/spec/ol/renderer/layer.test.js
+++ b/test/browser/spec/ol/renderer/layer.test.js
@@ -7,15 +7,32 @@ import View from '../../../../../src/ol/View.js';
 import XYZ from '../../../../../src/ol/source/XYZ.js';
 import {fromKey} from '../../../../../src/ol/tilecoord.js';
 
-describe('ol.renderer.Layer', function () {
-  let renderer;
+describe('ol/renderer/Layer', function () {
+  let layer, renderer;
   const eventType = 'change';
 
   beforeEach(function () {
-    const layer = new Layer({});
+    layer = new Layer({});
     renderer = new LayerRenderer(layer);
   });
 
+  describe('#renderIfReadyAndVisible', function () {
+    it('updates revision when data is ready and layer is visible', function () {
+      layer.setVisible(true);
+      let state;
+      layer.getSourceState = function () {
+        return state;
+      };
+      const revision = layer.getRevision();
+      state = 'foo';
+      renderer.renderIfReadyAndVisible();
+      expect(layer.getRevision()).to.be(revision);
+      state = 'ready';
+      renderer.renderIfReadyAndVisible();
+      expect(layer.getRevision()).to.be(revision + 1);
+    });
+  });
+
   describe('#loadImage', function () {
     let image;
     let imageLoadFunction;