ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

More consistent event types

Browse Source
This commit is contained in:
Tim Schaub
2013-12-11 16:26:33 -07:00
parent 625007f364
commit 69385f4ff0
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/ol/object.js
View File

@@ -21,7 +21,7 @@ goog.require('ol.Observable');
* @enum {string}
*/
ol.ObjectEventType = {
BEFORECHANGE: 'beforechange',
BEFOREPROPERTYCHANGE: 'beforepropertychange',
PROPERTYCHANGE: 'propertychange'
};
@@ -258,7 +258,7 @@ ol.Object.prototype.bindTo = function(key, target, opt_targetKey) {
// listen for beforechange events and relay if key matches
this.beforeChangeListeners_[key] = goog.events.listen(target,
ol.ObjectEventType.BEFORECHANGE,
ol.ObjectEventType.BEFOREPROPERTYCHANGE,
this.createBeforeChangeListener_(key, targetKey),
undefined, this);
@@ -288,7 +288,7 @@ ol.Object.prototype.createBeforeChangeListener_ = function(key, targetKey) {
return function(event) {
if (event.key === targetKey) {
this.dispatchEvent(
new ol.ObjectEvent(ol.ObjectEventType.BEFORECHANGE, key));
new ol.ObjectEvent(ol.ObjectEventType.BEFOREPROPERTYCHANGE, key));
}
};
};
@@ -408,7 +408,8 @@ ol.Object.prototype.notifyInternal_ = function(key) {
* @todo stability experimental
*/
ol.Object.prototype.set = function(key, value) {
this.dispatchEvent(new ol.ObjectEvent(ol.ObjectEventType.BEFORECHANGE, key));
this.dispatchEvent(
new ol.ObjectEvent(ol.ObjectEventType.BEFOREPROPERTYCHANGE, key));
var accessors = ol.Object.getAccessors(this);
if (accessors.hasOwnProperty(key)) {
var accessor = accessors[key];