set map.baseLayer to null when removing base layer - thanks for review elemoine (closes #1191).

git-svn-id: http://svn.openlayers.org/trunk/openlayers@5349 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Map.js

@@ -590,13 +590,15 @@ OpenLayers.Map = OpenLayers.Class({
         layer.map = null;
 
         // if we removed the base layer, need to set a new one
-        if (setNewBaseLayer && (this.baseLayer == layer)) {
+        if(this.baseLayer == layer) {
             this.baseLayer = null;
-            for(var i=0; i < this.layers.length; i++) {
+            if(setNewBaseLayer) {
-                var iLayer = this.layers[i];
+                for(var i=0; i < this.layers.length; i++) {
-                if (iLayer.isBaseLayer) {
+                    var iLayer = this.layers[i];
-                    this.setBaseLayer(iLayer);
+                    if (iLayer.isBaseLayer) {
-                    break;
+                        this.setBaseLayer(iLayer);
+                        break;
+                    }
                 }
             }
         }

tests/test_Map.html

@@ -306,6 +306,26 @@
         t.ok(map.baseLayer == wmslayer2, "setbaselayer correctly sets 'baseLayer' property");
     }
     
+    function test_Map_removeLayer(t) {
+        t.plan(1);
+        var f = function() {};
+        var layers = [
+            {name: "fee", removeMap: f},
+            {name: "fi", removeMap: f},
+            {name: "fo", removeMap: f},
+            {name: "fum", removeMap: f}
+        ];
+        var map = {
+            layers: layers,
+            baseLayer: layers[0],
+            layerContainerDiv: {removeChild: f},
+            events: {triggerEvent: f}
+        };
+        OpenLayers.Map.prototype.removeLayer.apply(map, [map.baseLayer, false]);
+        t.eq(map.baseLayer, null,
+             "removing the baselayer sets baseLayer to null");        
+    }
+
     function test_Map_removeLayer_res(t) {
         t.plan(2);