From 1f87dcc6b89b6ac910a92d30baab96805222d753 Mon Sep 17 00:00:00 2001 From: Murad Khafizov Date: Thu, 27 Apr 2017 16:00:12 +0200 Subject: [PATCH 1/2] fix crashing on using undefined segmentWriter --- src/ol/interaction/snap.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ol/interaction/snap.js b/src/ol/interaction/snap.js index 3e10becec3..ae54a67bca 100644 --- a/src/ol/interaction/snap.js +++ b/src/ol/interaction/snap.js @@ -418,8 +418,10 @@ ol.interaction.Snap.prototype.updateFeature_ = function(feature) { ol.interaction.Snap.prototype.writeGeometryCollectionGeometry_ = function(feature, geometry) { var i, geometries = geometry.getGeometriesArray(); for (i = 0; i < geometries.length; ++i) { - this.SEGMENT_WRITERS_[geometries[i].getType()].call( - this, feature, geometries[i]); + var segmentWriter = this.SEGMENT_WRITERS_[geometries[i].getType()]; + if(segmentWriter) { + segmentWriter.call(this, feature, geometries[i]); + } } }; From 242c55dcff6197dfbb1438f1f83b577af72f90f1 Mon Sep 17 00:00:00 2001 From: Murad Khafizov Date: Fri, 28 Apr 2017 10:45:28 +0200 Subject: [PATCH 2/2] formatting fixed --- src/ol/interaction/snap.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ol/interaction/snap.js b/src/ol/interaction/snap.js index ae54a67bca..a623d48f77 100644 --- a/src/ol/interaction/snap.js +++ b/src/ol/interaction/snap.js @@ -419,7 +419,7 @@ ol.interaction.Snap.prototype.writeGeometryCollectionGeometry_ = function(featur var i, geometries = geometry.getGeometriesArray(); for (i = 0; i < geometries.length; ++i) { var segmentWriter = this.SEGMENT_WRITERS_[geometries[i].getType()]; - if(segmentWriter) { + if (segmentWriter) { segmentWriter.call(this, feature, geometries[i]); } }