[ol.layer.TileLayer] use ol.error

This commit is contained in:
Éric Lemoine
2012-06-22 18:46:52 +02:00
parent a26913f26e
commit 5dc156995a
2 changed files with 10 additions and 9 deletions
+8 -7
View File
@@ -1,5 +1,6 @@
goog.provide('ol.layer.TileLayer'); goog.provide('ol.layer.TileLayer');
goog.require('ol.error');
goog.require('ol.layer.Layer'); goog.require('ol.layer.Layer');
goog.require('ol.Tile'); goog.require('ol.Tile');
goog.require('ol.TileCache'); goog.require('ol.TileCache');
@@ -182,7 +183,7 @@ ol.layer.TileLayer.prototype.getTileOrigin = function() {
goog.isDef(this.tileOriginY_)) { goog.isDef(this.tileOriginY_)) {
return [this.tileOriginX_, this.tileOriginY_]; return [this.tileOriginX_, this.tileOriginY_];
} }
var errmsg; var errmsg = 'Cannot calculate tile origin; ';
if (goog.isDef(this.tileOriginCorner_)) { if (goog.isDef(this.tileOriginCorner_)) {
var extent = this.getExtent(); var extent = this.getExtent();
if (!goog.isNull(extent)) { if (!goog.isNull(extent)) {
@@ -205,16 +206,16 @@ ol.layer.TileLayer.prototype.getTileOrigin = function() {
tileOriginY = extent.getMinY(); tileOriginY = extent.getMinY();
break; break;
default: default:
// FIXME user error errmsg += 'tileOriginCorner value is incorrect.';
goog.asserts.assert(false); ol.error(errmsg);
} }
return [tileOriginX, tileOriginY]; return [tileOriginX, tileOriginY];
} }
// FIXME user error errmsg += 'layer has no extent.';
goog.asserts.assert(false); ol.error(errmsg);
} }
// FIXME user error errmsg += 'layer has no tileOriginCorner.';
goog.asserts.assert(false); ol.error(errmsg);
return null; return null;
}; };
+2 -2
View File
@@ -97,7 +97,7 @@ describe('ol.layer.TileLayer', function() {
it('throws an error or return null', function() { it('throws an error or return null', function() {
var origin; var origin;
if (goog.DEBUG) { if (ol.error.VERBOSE_ERRORS) {
expect(function() { expect(function() {
origin = layer.getTileOrigin(); origin = layer.getTileOrigin();
}).toThrow(); }).toThrow();
@@ -118,7 +118,7 @@ describe('ol.layer.TileLayer', function() {
}); });
it('returns the expected origin', function() { it('returns the expected origin', function() {
if (goog.DEBUG) { if (ol.error.VERBOSE_ERRORS) {
expect(function() { expect(function() {
var origin = layer.getTileOrigin(); var origin = layer.getTileOrigin();
}).toThrow(); }).toThrow();