ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use goog.isString() instad of typeof check

Browse Source
This commit is contained in:
ahocevar
2013-05-16 21:20:34 +02:00
parent 22c4508c27
commit 5d7cdd2646
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ol/parser/kml.js
View File

@@ -564,7 +564,7 @@ ol.parser.KML = function(opt_options) {
'Document': function(options) { 'Document': function(options) {
var node = this.createElementNS('Document'); var node = this.createElementNS('Document');
for (var key in options) { for (var key in options) {
if (options.hasOwnProperty(key) && typeof options[key] === 'string') { if (options.hasOwnProperty(key) && goog.isString(options[key])) {
var child = this.createElementNS(key); var child = this.createElementNS(key);
child.appendChild(this.createTextNode(options[key])); child.appendChild(this.createTextNode(options[key]));
node.appendChild(child); node.appendChild(child);
@@ -878,7 +878,7 @@ ol.parser.KML.prototype.parseLinks = function(deferreds, obj, done) {
goog.events.listen(xhr, goog.net.EventType.COMPLETE, function(e) { goog.events.listen(xhr, goog.net.EventType.COMPLETE, function(e) {
if (e.target.isSuccess()) { if (e.target.isSuccess()) {
var data = e.target.getResponseXml() || e.target.getResponseText(); var data = e.target.getResponseXml() || e.target.getResponseText();
if (typeof data == 'string') { if (goog.isString(data)) {
data = goog.dom.xml.loadXml(data); data = goog.dom.xml.loadXml(data);
} }
goog.dispose(e.target); goog.dispose(e.target);
@@ -911,7 +911,7 @@ ol.parser.KML.prototype.parseLinks = function(deferreds, obj, done) {
* @return {Object} An object representing the document. * @return {Object} An object representing the document.
*/ */
ol.parser.KML.prototype.read = function(data, opt_callback) { ol.parser.KML.prototype.read = function(data, opt_callback) {
if (typeof data == 'string') { if (goog.isString(data)) {
data = goog.dom.xml.loadXml(data); data = goog.dom.xml.loadXml(data);
} }
if (data && data.nodeType == 9) { if (data && data.nodeType == 9) {