don’t duplicate defaults in renderers

This commit is contained in:
Antoine Abt
2012-01-05 10:26:05 +01:00
parent 0ff9d54d5c
commit 5be7e7f844
5 changed files with 23 additions and 12 deletions

View File

@@ -39,7 +39,10 @@
fontWeight: "bold", fontWeight: "bold",
labelAlign: "${align}", labelAlign: "${align}",
labelXOffset: "${xOffset}", labelXOffset: "${xOffset}",
labelYOffset: "${yOffset}" labelYOffset: "${yOffset}",
labelAlign: "cm",
labelOutlineColor: "white",
labelOutlineWidth: 3
}}), }}),
renderers: renderer renderers: renderer
}); });

View File

@@ -447,7 +447,11 @@ OpenLayers.Feature.Vector.style = {
hoverPointRadius: 1, hoverPointRadius: 1,
hoverPointUnit: "%", hoverPointUnit: "%",
pointerEvents: "visiblePainted", pointerEvents: "visiblePainted",
cursor: "inherit" cursor: "inherit",
fontColor: "#000000",
labelAlign: "cm",
labelOutlineColor: "white",
labelOutlineWidth: 3
}, },
'select': { 'select': {
fillColor: "blue", fillColor: "blue",
@@ -466,7 +470,12 @@ OpenLayers.Feature.Vector.style = {
hoverPointRadius: 1, hoverPointRadius: 1,
hoverPointUnit: "%", hoverPointUnit: "%",
pointerEvents: "visiblePainted", pointerEvents: "visiblePainted",
cursor: "pointer" cursor: "pointer",
fontColor: "#000000",
labelAlign: "cm",
labelOutlineColor: "white",
labelOutlineWidth: 3
}, },
'temporary': { 'temporary': {
fillColor: "#66cccc", fillColor: "#66cccc",
@@ -485,7 +494,12 @@ OpenLayers.Feature.Vector.style = {
hoverPointRadius: 1, hoverPointRadius: 1,
hoverPointUnit: "%", hoverPointUnit: "%",
pointerEvents: "visiblePainted", pointerEvents: "visiblePainted",
cursor: "inherit" cursor: "inherit",
fontColor: "#000000",
labelAlign: "cm",
labelOutlineColor: "white",
labelOutlineWidth: 3
}, },
'delete': { 'delete': {
display: "none" display: "none"

View File

@@ -525,12 +525,6 @@ OpenLayers.Renderer.Canvas = OpenLayers.Class(OpenLayers.Renderer, {
* style - {Object} * style - {Object}
*/ */
drawText: function(location, style) { drawText: function(location, style) {
style = OpenLayers.Util.extend({
fontColor: "#000000",
labelAlign: "cm",
labelOutlineColor: "white",
labelOutlineWidth: 3
}, style);
var pt = this.getLocalXY(location); var pt = this.getLocalXY(location);
this.setCanvasStyle("reset"); this.setCanvasStyle("reset");

View File

@@ -677,7 +677,7 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, {
} else { } else {
label.setAttributeNS(null, "pointer-events", "none"); label.setAttributeNS(null, "pointer-events", "none");
} }
var align = style.labelAlign || "cm"; var align = style.labelAlign;
label.setAttributeNS(null, "text-anchor", label.setAttributeNS(null, "text-anchor",
OpenLayers.Renderer.SVG.LABEL_ALIGN[align[0]] || "middle"); OpenLayers.Renderer.SVG.LABEL_ALIGN[align[0]] || "middle");

View File

@@ -584,7 +584,7 @@ OpenLayers.Renderer.SVG2 = OpenLayers.Class(OpenLayers.Renderer.NG, {
} else { } else {
text.setAttributeNS(null, "pointer-events", "none"); text.setAttributeNS(null, "pointer-events", "none");
} }
var align = style.labelAlign || "cm"; var align = style.labelAlign;
text.setAttributeNS(null, "text-anchor", text.setAttributeNS(null, "text-anchor",
OpenLayers.Renderer.SVG2.LABEL_ALIGN[align[0]] || "middle"); OpenLayers.Renderer.SVG2.LABEL_ALIGN[align[0]] || "middle");