From 5a1378cdab2f2180499763cbe4bf9a58451fdaba Mon Sep 17 00:00:00 2001 From: ahocevar Date: Sun, 22 Jan 2012 21:19:00 +0100 Subject: [PATCH] Improved extension example docs and destroy method. --- lib/OpenLayers/Events.js | 8 +++++--- lib/OpenLayers/Events/buttonclick.js | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/OpenLayers/Events.js b/lib/OpenLayers/Events.js index 224c46e7e9..907ced8109 100644 --- a/lib/OpenLayers/Events.js +++ b/lib/OpenLayers/Events.js @@ -486,10 +486,12 @@ OpenLayers.Events = OpenLayers.Class({ * this.target.extensions["fooend"] = true; * }, * destroy: function() { - * this.target.unregister("click", this, this.doStuff); + * var target = this.target; + * target.unregister("click", this, this.doStuff); + * delete this.target; * // only required if extension provides more than one event type - * delete this.target.extensions["foostart"]; - * delete this.target.extensions["fooend"]; + * delete target.extensions["foostart"]; + * delete target.extensions["fooend"]; * }, * doStuff: function(evt) { * var propagate = true; diff --git a/lib/OpenLayers/Events/buttonclick.js b/lib/OpenLayers/Events/buttonclick.js index 1485714d31..1fddfb705e 100644 --- a/lib/OpenLayers/Events/buttonclick.js +++ b/lib/OpenLayers/Events/buttonclick.js @@ -94,6 +94,7 @@ OpenLayers.Events.buttonclick = OpenLayers.Class({ for (var i=this.events.length-1; i>=0; --i) { this.target.unregister(this.events[i], this, this.buttonClick); } + delete this.target; }, /**