Bringing up patches from trunk to branch for RC3. -r8012:HEAD. (Closes #1594) (Closes #1730) (Closes #1735) (Closes #1738) (Closes #1740)

git-svn-id: http://svn.openlayers.org/branches/openlayers/2.7@8038 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/BaseTypes.js

@@ -340,7 +340,7 @@ if (!Number.prototype.limitSigDigs) {
      */
     Number.prototype.limitSigDigs = function(sig) {
         OpenLayers.Console.warn(OpenLayers.i18n("methodDeprecated",
-                              {'newMethod':'OpenLayers.String.limitSigDigs'}));
+                              {'newMethod':'OpenLayers.Number.limitSigDigs'}));
         return OpenLayers.Number.limitSigDigs(this, sig);
     };
 }
@@ -409,7 +409,7 @@ if (!Function.prototype.bind) {
      */
     Function.prototype.bind = function() {
         OpenLayers.Console.warn(OpenLayers.i18n("methodDeprecated",
-                                {'newMethod':'OpenLayers.String.bind'}));
+                                {'newMethod':'OpenLayers.Function.bind'}));
         // new function takes the same arguments with this function up front
         Array.prototype.unshift.apply(arguments, [this]);
         return OpenLayers.Function.bind.apply(null, arguments);
@@ -430,7 +430,7 @@ if (!Function.prototype.bindAsEventListener) {
      */
     Function.prototype.bindAsEventListener = function(object) {
         OpenLayers.Console.warn(OpenLayers.i18n("methodDeprecated",
-                        {'newMethod':'OpenLayers.String.bindAsEventListener'}));
+                        {'newMethod':'OpenLayers.Function.bindAsEventListener'}));
         return OpenLayers.Function.bindAsEventListener(this, object);
     };
 }

lib/OpenLayers/Console.js

@@ -233,10 +233,10 @@ OpenLayers.Console = {
      * If Firebug Lite is included (before this script), re-route all
      * OpenLayers.Console calls to the console object.
      */
-    if(window.console) {
-        var scripts = document.getElementsByTagName("script");
-        for(var i=0, len=scripts.length; i<len; ++i) {
-            if(scripts[i].src.indexOf("firebug.js") != -1) {
+    var scripts = document.getElementsByTagName("script");
+    for(var i=0, len=scripts.length; i<len; ++i) {
+        if(scripts[i].src.indexOf("firebug.js") != -1) {
+            if(console) {
                 OpenLayers.Util.extend(OpenLayers.Console, console);
                 break;
             }

lib/OpenLayers/Control/Attribution.js

@@ -10,6 +10,9 @@
  * Class: OpenLayers.Control.Attribution
  * Add attribution from layers to the map display. Uses 'attribution' property
  * of each layer.
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control>
  */
 OpenLayers.Control.Attribution = 
   OpenLayers.Class(OpenLayers.Control, {

lib/OpenLayers/Control/EditingToolbar.js

@@ -13,6 +13,9 @@
 
 /**
  * Class: OpenLayers.Control.EditingToolbar 
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control.Panel>
  */
 OpenLayers.Control.EditingToolbar = OpenLayers.Class(
   OpenLayers.Control.Panel, {

lib/OpenLayers/Control/MousePosition.js

@@ -9,6 +9,9 @@
 
 /**
  * Class: OpenLayers.Control.MousePosition
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control>
  */
 OpenLayers.Control.MousePosition = OpenLayers.Class(OpenLayers.Control, {
     

lib/OpenLayers/Control/Navigation.js

@@ -52,7 +52,7 @@ OpenLayers.Control.Navigation = OpenLayers.Class(OpenLayers.Control, {
      * APIProperty: handleRightClicks
      * {Boolean} Whether or not to handle right clicks. Default is false.
      */
-    handleRightClicks: true,
+    handleRightClicks: false,
     
     /**
      * Constructor: OpenLayers.Control.Navigation

lib/OpenLayers/Control/Pan.js

@@ -1,9 +1,16 @@
+/* Copyright (c) 2006-2008 MetaCarta, Inc., published under the Clear BSD
+ * license.  See http://svn.openlayers.org/trunk/openlayers/license.txt for the
+ * full text of the license. */
+
 /**
  * @requires OpenLayers/Control.js
  */
 
 /**
  * Class: OpenLayers.Control.Pan
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control>
  */
 OpenLayers.Control.Pan = OpenLayers.Class(OpenLayers.Control, {
 

lib/OpenLayers/Control/PanPanel.js

@@ -13,7 +13,9 @@
  * <!--[if lte IE 6]>
  *   <link rel="stylesheet" href="../theme/default/ie6-style.css" type="text/css" />
  * <![endif]-->
- * 
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control.Panel> 
  */
 OpenLayers.Control.PanPanel = OpenLayers.Class(OpenLayers.Control.Panel, {
 

lib/OpenLayers/Control/Scale.js

@@ -10,6 +10,7 @@
 /**
  * Class: OpenLayers.Control.Scale
  * Display a small scale indicator on the map.
+ *
  * Inherits from:
  *  - <OpenLayers.Control>
  */

lib/OpenLayers/Control/ZoomIn.js

@@ -1,9 +1,16 @@
+/* Copyright (c) 2006-2008 MetaCarta, Inc., published under the Clear BSD
+ * license.  See http://svn.openlayers.org/trunk/openlayers/license.txt for the
+ * full text of the license. */
+
 /**
  * @requires OpenLayers/Control.js
  */
 
 /**
  * Class: OpenLayers.Control.ZoomIn
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control>
  */
 OpenLayers.Control.ZoomIn = OpenLayers.Class(OpenLayers.Control, {
 

lib/OpenLayers/Control/ZoomOut.js

@@ -1,9 +1,16 @@
+/* Copyright (c) 2006-2008 MetaCarta, Inc., published under the Clear BSD
+ * license.  See http://svn.openlayers.org/trunk/openlayers/license.txt for the
+ * full text of the license. */
+
 /**
  * @requires OpenLayers/Control.js
  */
 
 /**
  * Class: OpenLayers.Control.ZoomOut
+ *
+ * Inherits from:
+ *  - <OpenLayers.Control>
  */
 OpenLayers.Control.ZoomOut = OpenLayers.Class(OpenLayers.Control, {
 
@@ -23,4 +30,4 @@ OpenLayers.Control.ZoomOut = OpenLayers.Class(OpenLayers.Control, {
     },
 
     CLASS_NAME: "OpenLayers.Control.ZoomOut"
-});
+});

lib/OpenLayers/Control/ZoomPanel.js

@@ -1,3 +1,7 @@
+/* Copyright (c) 2006-2008 MetaCarta, Inc., published under the Clear BSD
+ * license.  See http://svn.openlayers.org/trunk/openlayers/license.txt for the
+ * full text of the license. */
+
 /**
  * @requires OpenLayers/Control/Panel.js
  * @requires OpenLayers/Control/ZoomIn.js
@@ -16,6 +20,8 @@
  *   <link rel="stylesheet" href="../theme/default/ie6-style.css" type="text/css" />
  * <![endif]-->
  * 
+ * Inherits from:
+ *  - <OpenLayers.Control.Panel>
  */
 OpenLayers.Control.ZoomPanel = OpenLayers.Class(OpenLayers.Control.Panel, {
 

lib/OpenLayers/Control/ZoomToMaxExtent.js

@@ -8,7 +8,7 @@
 
 /**
  * Class: OpenLayers.Control.ZoomToMaxExtent 
- * Imlements a very simple button control. Designed to be used with a 
+ * Implements a very simple button control. Designed to be used with a 
  * <OpenLayers.Control.Panel>.
  * 
  * Inherits from:

lib/OpenLayers/Format/GML/Base.js

@@ -4,17 +4,9 @@
 
 /**
  * @requires OpenLayers/Format/XML.js
+ * @requires OpenLayers/Format/GML.js
  */
 
-/**
- * Eventually, this will require the OpenLayers.Format.GML.  For now, since
- *     this parser can be included in a lib without the old GML parser, we
- *     declare the namespace if it doesn't exist.
- */
-if(!OpenLayers.Format.GML) {
-    OpenLayers.Format.GML = {};
-}
-
 /**
  * Class: OpenLayers.Format.GML.Base
  * Superclass for GML parsers.

lib/OpenLayers/Format/WFS.js

@@ -9,6 +9,9 @@
 /**
  * Class: OpenLayers.Format.WFS
  * Read/Write WFS. 
+ *
+ * Inherits from:
+ *  - <OpenLayers.Format.GML>
  */
 OpenLayers.Format.WFS = OpenLayers.Class(OpenLayers.Format.GML, {
     

lib/OpenLayers/Protocol.js

@@ -11,13 +11,13 @@ OpenLayers.Protocol = OpenLayers.Class({
     
     /**
      * Property: format
-     * {<OpenLayers.Format>}
+     * {<OpenLayers.Format>} The format used by this protocol.
      */
     format: null,
     
     /**
      * Property: options
-     * Any options sent to the constructor.
+     * {Object} Any options sent to the constructor.
      */
     options: null,
 

lib/OpenLayers/Protocol/HTTP.js

@@ -19,14 +19,14 @@ OpenLayers.Protocol.HTTP = OpenLayers.Class(OpenLayers.Protocol, {
 
     /**
      * Property: url
-     * {String} - Service URL, read-only, set through the options
+     * {String} Service URL, read-only, set through the options
      *     passed to constructor.
      */
     url: null,
 
     /**
      * Property: headers
-     * {Object} - HTTP request headers, read-only, set through the options
+     * {Object} HTTP request headers, read-only, set through the options
      *     passed to the constructor,
      *     Example: {'Content-Type': 'plain/text'}
      */
@@ -34,7 +34,7 @@ OpenLayers.Protocol.HTTP = OpenLayers.Class(OpenLayers.Protocol, {
 
     /**
      * Property: params
-     * {Object} - Parameters of GET requests, read-only, set through the options
+     * {Object} Parameters of GET requests, read-only, set through the options
      *     passed to the constructor,
      *     Example: {'bbox': '5,5,5,5'}
      */
@@ -42,7 +42,7 @@ OpenLayers.Protocol.HTTP = OpenLayers.Class(OpenLayers.Protocol, {
     
     /**
      * Property: callback
-     * {Object} - Function to be called when the <read>, <create>,
+     * {Object} Function to be called when the <read>, <create>,
      *     <update>, <delete> or <commit> operation completes, read-only,
      *     set through the options passed to the constructor.
      */
@@ -50,7 +50,7 @@ OpenLayers.Protocol.HTTP = OpenLayers.Class(OpenLayers.Protocol, {
 
     /**
      * Property: scope
-     * {Object} - Callback execution scope, read-only, set through the
+     * {Object} Callback execution scope, read-only, set through the
      *     options passed to the constructor.
      */
     scope: null,

lib/OpenLayers/Renderer/SVG.js

@@ -661,7 +661,7 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, {
                 // If so, add the coordinate of the intersection with the
                 // valid range bounds.
                 if (i > 0) {
-                    if (this.getShortString(components[i + 1])) {
+                    if (this.getShortString(components[i - 1])) {
                         strings.push(this.clipLine(components[i],
                             components[i-1]));
                     }

lib/OpenLayers/Strategy.js

@@ -11,7 +11,7 @@ OpenLayers.Strategy = OpenLayers.Class({
     
     /**
      * Property: layer
-     * {<OpenLayers.Layer.Vector>}
+     * {<OpenLayers.Layer.Vector>} The layer this strategy belongs to.
      */
     layer: null,
     
@@ -69,7 +69,8 @@ OpenLayers.Strategy = OpenLayers.Class({
     },
 
     /**
-     * Method: setLayer.
+     * Method: setLayer
+     * Called to set the <layer> property.
      *
      * Parameters:
      * {<OpenLayers.Layer.Vector>}